Fix loan account conversion invariant

2026-10-07 03:58:52 +00:00
parent b8b8811a2a
commit 1b9eda683c
9 changed files with 219 additions and 2 deletions
@@ -0,0 +1,60 @@
+{
+  "schema": "gitea-agent.evidence-plan/v1",
+  "owner": "jsfamily",
+  "repository": "jarca-ledger-mcp",
+  "issue": 12,
+  "pull_request": 13,
+  "review_id": 61,
+  "reviewed_head": "5e721b0ddd648f3e80f341a3c304d1cc3ca47ee8",
+  "implementation_parent": "b8b8811a2a50371795a02e4fa65f097c9d9508ac",
+  "contract_sha256": "6d86b591b022fcc722611bfec6d24e54a64216ab6f7c4098f357e25420218818",
+  "manifest_generator": {
+    "path": "/opt/data/gitea-agent/.run/i12-r61/run_final_evidence.py",
+    "execution": "python3 /opt/data/gitea-agent/.run/i12-r61/run_final_evidence.py"
+  },
+  "commands": [
+    {
+      "id": "conversion-regression",
+      "argv": ["uv", "run", "--frozen", "--extra", "dev", "--extra", "dashboard", "pytest", "-q", "-rs", "tests/test_account_valuation_edge_contracts.py::test_bank_to_loan_conversion_rejects_existing_undefined_valuation_without_mutation", "tests/test_account_valuation_edge_contracts.py::test_bank_to_loan_conversion_without_valuations_remains_allowed"]
+    },
+    {
+      "id": "review61-regressions",
+      "argv": ["uv", "run", "--frozen", "--extra", "dev", "--extra", "dashboard", "pytest", "-q", "-rs", "tests/test_account_valuation_edge_contracts.py", "tests/test_issue_12_review59_account.py", "tests/test_valuation_contract_docs.py"]
+    },
+    {
+      "id": "full-suite",
+      "argv": ["uv", "run", "--frozen", "--extra", "dev", "--extra", "dashboard", "pytest", "-q", "-rs"]
+    },
+    {
+      "id": "ruff",
+      "argv": ["uv", "run", "--frozen", "--extra", "dev", "--extra", "dashboard", "ruff", "check", "."]
+    },
+    {
+      "id": "compileall",
+      "argv": ["python3", "-m", "compileall", "-q", "jarca_ledger_mcp", "dashboard", "tests", "scripts"]
+    },
+    {
+      "id": "diff-check",
+      "argv": ["git", "diff", "--check", "5e721b0ddd648f3e80f341a3c304d1cc3ca47ee8..<SOURCE_SHA>"]
+    }
+  ],
+  "bound_paths": [
+    "jarca_ledger_mcp/application/account_valuation_service.py",
+    "jarca_ledger_mcp/application/accounts_write_services.py",
+    "tests/test_account_valuation_edge_contracts.py",
+    "tests/test_issue_12_review59_account.py",
+    "tests/test_valuation_contract_docs.py",
+    "docs/data-model.md",
+    "docs/interface-contract.md",
+    "docs/requirements/req-003_account-valuation-history.md",
+    "docs/verification/issue-12-review-61/red-evidence.json",
+    "docs/verification/issue-12-review-61/finding-matrix.json",
+    "docs/verification/issue-12-review-61/contract-preservation-inventory.json",
+    "docs/verification/issue-12-review-61/evidence-plan.json"
+  ],
+  "redaction": "Synthetic fixtures only; no credentials, real account identifiers, financial documents, or environment secrets.",
+  "limitations": [
+    "External private PDF fixtures may be skipped when unavailable.",
+    "Gitea commit status is readiness metadata, not functional acceptance evidence."
+  ]
+}