jsfamily/jarca-ledger-mcp
5
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Reject invalid balances on account updates

Browse Source
This commit is contained in:
gitea-impl-agent
2026-10-07 22:09:02 +00:00
parent 3bf9b77c6c
commit 31d1c11dcf
2 changed files with 82 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
jarca_ledger_mcp/application/accounts_write_services.py
+10 -3
View File
@@ -48,8 +48,15 @@ def update_ledger_account(account_id: str, db_path: str | None = None, **fields:
if current is None: return fail("not_found", "account not found")
balance_update = "last_balance" in fields and fields.get("last_balance") is not None
basis_update = "last_balance_basis_date" in fields and fields.get("last_balance_basis_date") is not None
if basis_update and (not balance_update or fields.get("last_balance") == ""):
if basis_update and not balance_update:
return fail("validation_error", "last_balance_basis_date requires last_balance")
normalized_balance = None
if balance_update:
try:
from .account_valuation_service import _strict_int
normalized_balance = _strict_int(fields["last_balance"], "last_balance", allow_none=False)
except (ValueError, TypeError) as e:
return fail("validation_error", str(e))
normalized_basis = None
if basis_update:
try:
@@ -64,7 +71,7 @@ def update_ledger_account(account_id: str, db_path: str | None = None, **fields:
if k == "statement_status": v = normalize_statement_status(str(v))
if k == "liquidity_bucket": v = normalize_liquidity_bucket(str(v))
if k == "active": v = int(bool(v))
if k == "last_balance" and v != "": v = int(v)
if k == "last_balance": v = normalized_balance
if k == "currency": v = str(v).upper()
if k == "last_balance_basis_date": v = normalized_basis
except Exception as e: return fail("validation_error", str(e))
@@ -83,7 +90,7 @@ def update_ledger_account(account_id: str, db_path: str | None = None, **fields:
stored_date = str(current["last_balance_basis_date"] or "")[:10]
incoming_date = normalized_basis if basis_update else ""
historical = bool(balance_update and incoming_date and stored_date and incoming_date < stored_date)
candidate_balance = fields.get("last_balance", current["last_balance"])
candidate_balance = normalized_balance if balance_update else current["last_balance"]
if historical:
kept=[(u,p) for u,p in zip(updates,params) if not u.startswith(("last_balance=","last_balance_basis_date=","last_synced_at="))]
updates=[u for u,_ in kept]; params=[p for _,p in kept]