fix: preserve correction and legacy authority semantics

2026-10-06 09:05:54 +00:00
parent 921f130fb0
commit a4cad342a6
4 changed files with 60 additions and 6 deletions
@@ -266,19 +266,19 @@ def correct_account_valuation(valuation_id: str, amount: int, correction_reason:
        source = conn.execute("SELECT * FROM account_valuations WHERE id=?", (valuation_id,)).fetchone()
        if source is None:
            return fail("not_found", "valuation not found")
+        preserved = {name: fields[name] if name in fields else source[name] for name in (
+            "currency", "valuation_kind", "source_type", "source_ref", "verification_status", "memo", "as_of_at", "timezone",
+            "cost_basis", "net_contributed", "reported_principal_kind", "reported_principal_label", "profit", "return_rate", "return_basis", "principal", "interest", "fee", "representative_liability_definition")}
        if idempotency_key:
            prior = conn.execute("SELECT * FROM account_valuations WHERE account_id=? AND idempotency_key=?", (source["account_id"], idempotency_key)).fetchone()
            if prior:
                expected = {"amount": amount, "supersedes_id": valuation_id, "correction_reason": correction_reason.strip()}
-                expected.update({k: fields[k] for k in fields})
+                expected.update(preserved)
                if all(prior[k] == v for k, v in expected.items() if k in prior.keys()):
                    return ok(valuation=_valuation(prior), reused=True)
                return fail("idempotency_conflict", "idempotency_key already has a different payload", valuation=_valuation(prior))
        if conn.execute("SELECT 1 FROM account_valuations WHERE supersedes_id=?", (valuation_id,)).fetchone():
            return fail("correction_conflict", "valuation already has a correction")
-    preserved = {name: fields[name] if name in fields else source[name] for name in (
-        "currency", "valuation_kind", "source_type", "source_ref", "verification_status", "memo", "as_of_at", "timezone",
-        "cost_basis", "net_contributed", "reported_principal_kind", "reported_principal_label", "profit", "return_rate", "return_basis", "principal", "interest", "fee", "representative_liability_definition")}
    return register_account_valuation(
        source["account_id"], source["basis_date"], amount,
        **preserved,