Fix Review 64 valuation authority regressions

2026-10-07 13:39:26 +00:00
parent c7a9cfa50d
commit e41db959e4
6 changed files with 220 additions and 7 deletions
@@ -1,10 +1,133 @@
 from __future__ import annotations

+import json
 import sqlite3

 from jarca_ledger_mcp import service


+def test_replay_preserves_redacted_unverified_candidates_after_correction(tmp_path):
+    db_path = str(tmp_path / "ledger.sqlite3")
+    account = service.create_ledger_account("투자 계좌", type="investment", db_path=db_path)
+    account_id = account["account"]["id"]
+    verified = service.register_account_valuation(
+        account_id, "2026-06-30", 100, verification_status="verified",
+        idempotency_key="valuation-verified", db_path=db_path,
+    )
+    candidate = service.register_account_valuation(
+        account_id, "2026-06-30", 110, verification_status="unverified",
+        idempotency_key="valuation-candidate", db_path=db_path,
+    )
+
+    first = service.close_asset_snapshot(
+        "2026-06-30", idempotency_key="candidate-close-a", db_path=db_path,
+    )
+    assert first["success"] is True
+    assert first["included_items"][0]["unverified_candidates"] == [{
+        "id": candidate["valuation"]["id"],
+        "basis_date": "2026-06-30",
+        "currency": "KRW",
+        "valuation_kind": "balance",
+        "verification_status": "unverified",
+    }]
+    assert {warning["blocking"] for warning in first["warnings"] if warning["code"] == "unverified_candidate"} == {False}
+    assert first["included_items"][0]["valuation_id"] == verified["valuation"]["id"]
+    with sqlite3.connect(db_path) as conn:
+        persisted = conn.execute("SELECT applied_evidence, excluded_evidence FROM asset_snapshot_runs WHERE id=?", (first["snapshot_run_id"],)).fetchone()
+    applied_evidence, excluded_evidence = map(json.loads, persisted)
+    assert applied_evidence[0]["unverified_candidates"] == first["included_items"][0]["unverified_candidates"]
+    candidate_evidence = [item for item in excluded_evidence if item.get("reason") == "unverified_candidate"]
+    assert candidate_evidence[0]["candidate"] == first["included_items"][0]["unverified_candidates"][0]
+    assert candidate_evidence[0]["blocking"] is False
+    assert candidate_evidence[0]["state_hash"]
+
+    corrected = service.close_asset_snapshot(
+        "2026-06-30", correction_reason="preserve evidence", idempotency_key="candidate-close-b",
+        db_path=db_path,
+    )
+    assert corrected["success"] is True
+
+    with sqlite3.connect(db_path) as conn:
+        before_replay = conn.execute("SELECT COUNT(*) FROM asset_snapshots").fetchone()[0]
+        before_runs = conn.execute("SELECT COUNT(*) FROM asset_snapshot_runs").fetchone()[0]
+    replay = service.close_asset_snapshot(
+        "2026-06-30", idempotency_key="candidate-close-a", db_path=db_path,
+    )
+    with sqlite3.connect(db_path) as conn:
+        after_replay = conn.execute("SELECT COUNT(*) FROM asset_snapshots").fetchone()[0]
+        after_runs = conn.execute("SELECT COUNT(*) FROM asset_snapshot_runs").fetchone()[0]
+
+    assert replay == first
+    assert replay["included_items"] == first["included_items"]
+    assert replay["warnings"] == first["warnings"]
+    assert after_replay == before_replay
+    assert after_runs == before_runs
+
+
+def test_replay_preserves_blocking_candidate_warning_shape(tmp_path):
+    db_path = str(tmp_path / "ledger.sqlite3")
+    account_id = service.create_ledger_account(
+        "미확인 계좌", type="investment", db_path=db_path,
+    )["account"]["id"]
+    service.register_account_valuation(
+        account_id, "2026-06-30", 110, verification_status="unverified",
+        idempotency_key="only-candidate", db_path=db_path,
+    )
+
+    first = service.close_asset_snapshot(
+        "2026-06-30", idempotency_key="blocking-candidate-close",
+        allow_missing_exclusions=True, approved_by="reviewer",
+        approval_reason="exclude unverified evidence",
+        approval_reference="synthetic-approval", db_path=db_path,
+    )
+    assert first["success"] is True
+    warning = next(item for item in first["warnings"] if item["code"] == "unverified_candidate")
+    assert "blocking" not in warning
+
+    replay = service.close_asset_snapshot(
+        "2026-06-30", idempotency_key="blocking-candidate-close",
+        allow_missing_exclusions=True, approved_by="reviewer",
+        approval_reason="exclude unverified evidence",
+        approval_reference="synthetic-approval", db_path=db_path,
+    )
+
+    assert replay == first
+    replay_warning = next(item for item in replay["warnings"] if item["code"] == "unverified_candidate")
+    assert "blocking" not in replay_warning
+
+
+def test_malformed_persisted_evidence_fails_closed_without_snapshot_writes(tmp_path):
+    db_path = str(tmp_path / "ledger.sqlite3")
+    service.create_manual_asset("현금", 100, "2026-06-30", "cash", db_path=db_path)
+    first = service.close_asset_snapshot(
+        "2026-06-30", idempotency_key="malformed-evidence-close", db_path=db_path,
+    )
+    assert first["success"] is True
+
+    with sqlite3.connect(db_path) as conn:
+        conn.execute(
+            "UPDATE asset_snapshot_runs SET excluded_evidence=? WHERE id=?",
+            ("{malformed", first["snapshot_run_id"]),
+        )
+        before_rows = conn.execute("SELECT COUNT(*) FROM asset_snapshots").fetchone()[0]
+        before_runs = conn.execute("SELECT COUNT(*) FROM asset_snapshot_runs").fetchone()[0]
+
+    report = service.get_asset_snapshot_report("2026-06-30", db_path=db_path)
+    replay = service.close_asset_snapshot(
+        "2026-06-30", idempotency_key="malformed-evidence-close", db_path=db_path,
+    )
+    timeseries = service.get_net_worth_timeseries(
+        "2026-06-01", "2026-06-30", db_path=db_path,
+    )
+
+    for result in (report, replay, timeseries):
+        assert result["success"] is False
+        assert result["error_code"] == "data_integrity_error"
+    with sqlite3.connect(db_path) as conn:
+        assert conn.execute("SELECT COUNT(*) FROM asset_snapshots").fetchone()[0] == before_rows
+        assert conn.execute("SELECT COUNT(*) FROM asset_snapshot_runs").fetchone()[0] == before_runs
+
+
 def test_exact_run_replay_after_correction_reconstructs_original_persisted_run(tmp_path):
    db_path = str(tmp_path / "ledger.sqlite3")
    service.create_manual_asset("현금", 100, "2026-06-30", "cash", db_path=db_path)