{ "schema": "review-red-evidence/v1", "issue": 12, "pull_request": 13, "review_id": 63, "reviewed_head": "3b5101128d5a2cf038b8fb84facfd9d176928c26", "review_state": "REQUEST_CHANGES", "findings": [ { "id": "F-001", "test": "test_f001_preview_fingerprint_uses_same_unredacted_authority_and_rejects_drift", "red_observation": "unchanged preview fingerprint was rejected with authority_drift" }, { "id": "F-002", "tests": [ "test_f002_close_replay_is_byte_for_byte_equal_for_mixed_account_manual_as_of", "test_f002_correction_replay_preserves_full_initial_response" ], "red_observation": "replay responses differed in warnings/provenance/items or conflicted" }, { "id": "F-003", "test": "test_f003_zero_row_conditional_runs_are_timeseries_authority_with_aliases", "red_observation": "zero-row closed run produced no timeseries point" }, { "id": "F-004", "test": "test_f004_closed_report_restores_frozen_valuation_identity_without_legacy_invention", "red_observation": "closed report omitted persisted valuation_id and currency" }, { "id": "F-005", "tests": [ "test_create_rejects_basis_only_without_mutation", "test_basis_only_create_cannot_block_later_dated_import" ], "red_observation": "basis-only account creation succeeded and could suppress a real dated import balance" }, { "id": "F-006", "test": "test_f006_initial_replay_survives_multiple_later_corrections", "red_observation": "replaying the initial idempotency key after two later corrections returned idempotency_conflict" } ], "red_runs": [ { "argv": ["pytest", "-q", "tests/test_issue_12_review63_assets.py"], "exit_code": 1, "result": "5 failed before production changes", "limitation": "isolated development environment used by the delegated TDD worker" }, { "argv": ["uv", "run", "pytest", "-q", "tests/test_issue_12_review63_accounts.py"], "exit_code": 1, "result": "2 failed before production changes" }, { "argv": ["uv", "run", "--frozen", "--extra", "dev", "--extra", "dashboard", "pytest", "-o", "addopts=", "-q", "tests/test_issue_12_review63_assets.py::test_f002_correction_replay_preserves_full_initial_response"], "exit_code": 1, "result": "correction replay omitted existing_snapshot_rows and differed from the original response" }, { "argv": ["uv", "run", "--frozen", "--extra", "dev", "--extra", "dashboard", "pytest", "-o", "addopts=", "-q", "tests/test_issue_12_review63_assets.py::test_f006_initial_replay_survives_multiple_later_corrections"], "exit_code": 1, "result": "initial replay after two later corrections returned idempotency_conflict" } ] }