60 lines
2.6 KiB
JSON
60 lines
2.6 KiB
JSON
{
|
|
"schema": "review-finding-matrix/v1",
|
|
"issue": 12,
|
|
"pull_request": 13,
|
|
"review_id": 63,
|
|
"reviewed_head": "3b5101128d5a2cf038b8fb84facfd9d176928c26",
|
|
"source_revision": "bce25f9106f1914361e7a2bdc74000d87d4a0660",
|
|
"findings": [
|
|
{
|
|
"id": "F-001",
|
|
"status": "resolved",
|
|
"production": "jarca_ledger_mcp/application/assets_service.py",
|
|
"regression": "test_f001_preview_fingerprint_uses_same_unredacted_authority_and_rejects_drift",
|
|
"claim": "preview and close hash the same private authority representation; real drift is rejected without a run write"
|
|
},
|
|
{
|
|
"id": "F-002",
|
|
"status": "resolved",
|
|
"production": "jarca_ledger_mcp/application/assets_service.py",
|
|
"regressions": [
|
|
"test_f002_close_replay_is_byte_for_byte_equal_for_mixed_account_manual_as_of",
|
|
"test_f002_correction_replay_preserves_full_initial_response"
|
|
],
|
|
"claim": "initial and correction replays reconstruct the original immutable response, warning set, provenance, item ordering, and IDs"
|
|
},
|
|
{
|
|
"id": "F-003",
|
|
"status": "resolved",
|
|
"production": "jarca_ledger_mcp/application/assets_service.py",
|
|
"regression": "test_f003_zero_row_conditional_runs_are_timeseries_authority_with_aliases",
|
|
"claim": "timeseries enumerates both legacy snapshot and run-only basis dates and exposes the latest zero-row conditional run"
|
|
},
|
|
{
|
|
"id": "F-004",
|
|
"status": "resolved",
|
|
"production": "jarca_ledger_mcp/application/assets_service.py",
|
|
"regression": "test_f004_closed_report_restores_frozen_valuation_identity_without_legacy_invention",
|
|
"claim": "closed reports restore persisted valuation identity and currency without consulting live authority or inventing legacy IDs"
|
|
},
|
|
{
|
|
"id": "F-005",
|
|
"status": "resolved",
|
|
"production": "jarca_ledger_mcp/application/accounts_write_services.py",
|
|
"regressions": [
|
|
"test_create_rejects_basis_only_without_mutation",
|
|
"test_basis_only_create_cannot_block_later_dated_import"
|
|
],
|
|
"claim": "basis-only creates fail before mutation while zero-with-basis and unknown pairs remain valid"
|
|
},
|
|
{
|
|
"id": "F-006",
|
|
"status": "resolved",
|
|
"production": "jarca_ledger_mcp/application/assets_service.py",
|
|
"regression": "test_f006_initial_replay_survives_multiple_later_corrections",
|
|
"claim": "an immutable run can be replayed through the complete later correction chain while unrelated live-authority drift still conflicts"
|
|
}
|
|
],
|
|
"green_evidence": "evidence-manifest.json"
|
|
}
|