feat: asset catalog API, 태그 DB 기초, 마이그레이션 3건 및 도메인/테스트 갱신 (2026-05-19)
This commit is contained in:
@@ -246,3 +246,507 @@ def test_migration_rev_b_has_data_migration_insert() -> None:
|
||||
content = open(os.path.join(migrations_dir, rev_b)).read()
|
||||
assert "INSERT INTO assets" in content
|
||||
assert "ARRAY_AGG" in content
|
||||
|
||||
|
||||
# ===========================================================================
|
||||
# REQ-010: Admin asset catalog CRUD
|
||||
# ===========================================================================
|
||||
|
||||
# ---------------------------------------------------------------------------
|
||||
# REQ-010 CLI: FakeRepo for asset CRUD
|
||||
# ---------------------------------------------------------------------------
|
||||
|
||||
_ASSET_UUID = "00000000-0000-0000-0000-000000000099"
|
||||
|
||||
|
||||
class _AssetFakeRepo:
|
||||
"""Minimal in-memory repo supporting asset CRUD for CLI tests."""
|
||||
|
||||
def __init__(self) -> None:
|
||||
self._assets: dict[str, Asset] = {}
|
||||
self._seq = 1
|
||||
|
||||
def insert_asset(
|
||||
self,
|
||||
*,
|
||||
symbol: str,
|
||||
markets: list[str],
|
||||
display_name: str | None = None,
|
||||
status: str = "active",
|
||||
) -> Asset:
|
||||
now = __import__("datetime").datetime.now(__import__("datetime").timezone.utc)
|
||||
asset_id = f"00000000-0000-0000-0000-{self._seq:012d}"
|
||||
self._seq += 1
|
||||
asset = Asset(
|
||||
asset_id=asset_id, symbol=symbol, markets=markets,
|
||||
display_name=display_name, status=status,
|
||||
created_at=now, updated_at=now,
|
||||
)
|
||||
self._assets[asset_id] = asset
|
||||
return asset
|
||||
|
||||
def update_asset(
|
||||
self,
|
||||
asset_id: str,
|
||||
*,
|
||||
markets: list[str] | None = None,
|
||||
display_name: str | None = None,
|
||||
status: str | None = None,
|
||||
) -> Asset:
|
||||
asset = self._assets.get(asset_id)
|
||||
if asset is None:
|
||||
raise ValueError(f"asset not found: {asset_id}")
|
||||
import dataclasses
|
||||
fields = dataclasses.asdict(asset)
|
||||
if markets is not None:
|
||||
fields["markets"] = markets
|
||||
if display_name is not None:
|
||||
fields["display_name"] = display_name
|
||||
if status is not None:
|
||||
fields["status"] = status
|
||||
updated = Asset(**fields)
|
||||
self._assets[asset_id] = updated
|
||||
return updated
|
||||
|
||||
def list_assets(self) -> list[Asset]:
|
||||
return list(self._assets.values())
|
||||
|
||||
def close(self) -> None:
|
||||
pass
|
||||
|
||||
def ensure_schema(self) -> None:
|
||||
pass
|
||||
|
||||
|
||||
def _build_asset_runner(repo: _AssetFakeRepo):
|
||||
from typer.testing import CliRunner
|
||||
from app.cli.main import create_app
|
||||
from app.core.config import Settings
|
||||
|
||||
settings = Settings(allowed_origins_raw="http://localhost:3000")
|
||||
app = create_app(
|
||||
settings_factory=lambda: settings,
|
||||
repository_factory=lambda _: repo,
|
||||
)
|
||||
return CliRunner(), app
|
||||
|
||||
|
||||
# REQ-010 AC-1: pfhub asset create
|
||||
def test_asset_cli_create_success() -> None:
|
||||
repo = _AssetFakeRepo()
|
||||
runner, app = _build_asset_runner(repo)
|
||||
result = runner.invoke(app, ["asset", "create", "005930", "--market", "KRX", "--force"])
|
||||
assert result.exit_code == 0, result.output
|
||||
assert "005930" in result.output
|
||||
|
||||
|
||||
# REQ-010 AC-2: pfhub asset list — active/inactive filter
|
||||
def test_asset_cli_list_returns_all() -> None:
|
||||
repo = _AssetFakeRepo()
|
||||
repo.insert_asset(symbol="AAPL", markets=["NASDAQ"], status="active")
|
||||
repo.insert_asset(symbol="BTC", markets=["UPBIT"], status="inactive")
|
||||
runner, app = _build_asset_runner(repo)
|
||||
result = runner.invoke(app, ["asset", "list"])
|
||||
assert result.exit_code == 0, result.output
|
||||
assert "AAPL" in result.output
|
||||
assert "BTC" in result.output
|
||||
|
||||
|
||||
def test_asset_cli_list_active_only_filter() -> None:
|
||||
repo = _AssetFakeRepo()
|
||||
repo.insert_asset(symbol="AAPL", markets=["NASDAQ"], status="active")
|
||||
repo.insert_asset(symbol="BTC", markets=["UPBIT"], status="inactive")
|
||||
runner, app = _build_asset_runner(repo)
|
||||
result = runner.invoke(app, ["asset", "list", "--active-only"])
|
||||
assert result.exit_code == 0, result.output
|
||||
assert "AAPL" in result.output
|
||||
assert "BTC" not in result.output
|
||||
|
||||
|
||||
# REQ-010 AC-3: pfhub asset update
|
||||
def test_asset_cli_update_success() -> None:
|
||||
repo = _AssetFakeRepo()
|
||||
asset = repo.insert_asset(symbol="005930", markets=["KRX"])
|
||||
runner, app = _build_asset_runner(repo)
|
||||
result = runner.invoke(app, [
|
||||
"asset", "update", asset.asset_id,
|
||||
"--display-name", "Samsung Electronics",
|
||||
"--force",
|
||||
])
|
||||
assert result.exit_code == 0, result.output
|
||||
assert "005930" in result.output
|
||||
|
||||
|
||||
# REQ-010 AC-4: pfhub asset deactivate
|
||||
def test_asset_cli_deactivate_success() -> None:
|
||||
repo = _AssetFakeRepo()
|
||||
asset = repo.insert_asset(symbol="005930", markets=["KRX"])
|
||||
runner, app = _build_asset_runner(repo)
|
||||
result = runner.invoke(app, ["asset", "deactivate", asset.asset_id, "--force"])
|
||||
assert result.exit_code == 0, result.output
|
||||
assert repo._assets[asset.asset_id].status == "inactive"
|
||||
|
||||
|
||||
# ---------------------------------------------------------------------------
|
||||
# REQ-010 HTTP: admin catalog endpoints
|
||||
# ---------------------------------------------------------------------------
|
||||
|
||||
def _make_catalog_http_client(monkeypatch=None):
|
||||
"""Build TestClient with mock admin-auth for catalog endpoint tests."""
|
||||
from unittest.mock import MagicMock, patch
|
||||
from fastapi.testclient import TestClient
|
||||
from app.main import create_app
|
||||
from app.core.config import Settings, get_settings
|
||||
from app.domain.models import TokenPrincipal
|
||||
|
||||
_ENC_KEY = "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA="
|
||||
settings = Settings(
|
||||
allowed_origins_raw="http://localhost:3000",
|
||||
db_enabled=True,
|
||||
credential_encryption_key=_ENC_KEY,
|
||||
)
|
||||
admin_principal = TokenPrincipal(
|
||||
token_id="t-admin", user_id="admin-1", permission="admin",
|
||||
token_type="admin", runtime_id="rt-1",
|
||||
)
|
||||
mock_repo = MagicMock()
|
||||
mock_repo.get_token_principal.return_value = admin_principal
|
||||
return mock_repo, settings
|
||||
|
||||
|
||||
def _make_asset_obj(asset_id: str = _ASSET_UUID, symbol: str = "005930") -> Asset:
|
||||
from datetime import datetime, timezone
|
||||
return Asset(
|
||||
asset_id=asset_id,
|
||||
symbol=symbol,
|
||||
markets=["KRX"],
|
||||
display_name="Samsung",
|
||||
status="active",
|
||||
created_at=datetime.now(timezone.utc),
|
||||
updated_at=datetime.now(timezone.utc),
|
||||
)
|
||||
|
||||
|
||||
def test_asset_http_create_returns_201() -> None:
|
||||
from unittest.mock import MagicMock, patch
|
||||
from fastapi.testclient import TestClient
|
||||
from app.main import create_app
|
||||
from app.core.config import Settings, get_settings
|
||||
from app.domain.models import TokenPrincipal
|
||||
|
||||
_ENC_KEY = "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA="
|
||||
settings = Settings(
|
||||
allowed_origins_raw="http://localhost:3000",
|
||||
db_enabled=True,
|
||||
credential_encryption_key=_ENC_KEY,
|
||||
)
|
||||
admin_principal = TokenPrincipal(
|
||||
token_id="t-admin", user_id="admin-1", permission="admin",
|
||||
token_type="admin", runtime_id="rt-1",
|
||||
)
|
||||
mock_repo = MagicMock()
|
||||
mock_repo.get_token_principal.return_value = admin_principal
|
||||
mock_repo.insert_asset.return_value = _make_asset_obj()
|
||||
|
||||
with patch("app.core.auth.get_portfolio_repository_from_settings", return_value=mock_repo), \
|
||||
patch("app.api.v1_assets.get_portfolio_repository_from_settings", return_value=mock_repo):
|
||||
app = create_app(settings_factory=lambda: settings)
|
||||
app.dependency_overrides[get_settings] = lambda: settings
|
||||
client = TestClient(app)
|
||||
resp = client.post(
|
||||
"/v1/assets",
|
||||
json={"symbol": "005930", "markets": ["KRX"]},
|
||||
headers={"Authorization": "Bearer admin-token"},
|
||||
)
|
||||
|
||||
assert resp.status_code == 201
|
||||
body = resp.json()
|
||||
assert body["symbol"] == "005930"
|
||||
assert body["status"] == "active"
|
||||
assert "asset_id" in body
|
||||
|
||||
|
||||
def test_asset_http_update_returns_200() -> None:
|
||||
from unittest.mock import MagicMock, patch
|
||||
from fastapi.testclient import TestClient
|
||||
from app.main import create_app
|
||||
from app.core.config import Settings, get_settings
|
||||
from app.domain.models import TokenPrincipal
|
||||
|
||||
_ENC_KEY = "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA="
|
||||
settings = Settings(
|
||||
allowed_origins_raw="http://localhost:3000",
|
||||
db_enabled=True,
|
||||
credential_encryption_key=_ENC_KEY,
|
||||
)
|
||||
admin_principal = TokenPrincipal(
|
||||
token_id="t-admin", user_id="admin-1", permission="admin",
|
||||
token_type="admin", runtime_id="rt-1",
|
||||
)
|
||||
mock_repo = MagicMock()
|
||||
mock_repo.get_token_principal.return_value = admin_principal
|
||||
mock_repo.update_asset.return_value = _make_asset_obj()
|
||||
|
||||
with patch("app.core.auth.get_portfolio_repository_from_settings", return_value=mock_repo), \
|
||||
patch("app.api.v1_assets.get_portfolio_repository_from_settings", return_value=mock_repo):
|
||||
app = create_app(settings_factory=lambda: settings)
|
||||
app.dependency_overrides[get_settings] = lambda: settings
|
||||
client = TestClient(app)
|
||||
resp = client.patch(
|
||||
f"/v1/assets/{_ASSET_UUID}",
|
||||
json={"display_name": "Samsung Electronics"},
|
||||
headers={"Authorization": "Bearer admin-token"},
|
||||
)
|
||||
|
||||
assert resp.status_code == 200
|
||||
assert resp.json()["asset_id"] == _ASSET_UUID
|
||||
|
||||
|
||||
def test_asset_http_deactivate_returns_200() -> None:
|
||||
from unittest.mock import MagicMock, patch
|
||||
from fastapi.testclient import TestClient
|
||||
from app.main import create_app
|
||||
from app.core.config import Settings, get_settings
|
||||
from app.domain.models import TokenPrincipal
|
||||
|
||||
_ENC_KEY = "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA="
|
||||
settings = Settings(
|
||||
allowed_origins_raw="http://localhost:3000",
|
||||
db_enabled=True,
|
||||
credential_encryption_key=_ENC_KEY,
|
||||
)
|
||||
admin_principal = TokenPrincipal(
|
||||
token_id="t-admin", user_id="admin-1", permission="admin",
|
||||
token_type="admin", runtime_id="rt-1",
|
||||
)
|
||||
inactive_asset = _make_asset_obj()
|
||||
import dataclasses
|
||||
inactive_asset = dataclasses.replace(inactive_asset, status="inactive")
|
||||
|
||||
mock_repo = MagicMock()
|
||||
mock_repo.get_token_principal.return_value = admin_principal
|
||||
mock_repo.update_asset.return_value = inactive_asset
|
||||
|
||||
with patch("app.core.auth.get_portfolio_repository_from_settings", return_value=mock_repo), \
|
||||
patch("app.api.v1_assets.get_portfolio_repository_from_settings", return_value=mock_repo):
|
||||
app = create_app(settings_factory=lambda: settings)
|
||||
app.dependency_overrides[get_settings] = lambda: settings
|
||||
client = TestClient(app)
|
||||
resp = client.patch(
|
||||
f"/v1/assets/{_ASSET_UUID}/deactivate",
|
||||
headers={"Authorization": "Bearer admin-token"},
|
||||
)
|
||||
|
||||
assert resp.status_code == 200
|
||||
assert resp.json()["status"] == "inactive"
|
||||
|
||||
|
||||
def test_asset_http_non_admin_403() -> None:
|
||||
from unittest.mock import MagicMock, patch
|
||||
from fastapi.testclient import TestClient
|
||||
from app.main import create_app
|
||||
from app.core.config import Settings, get_settings
|
||||
from app.domain.models import TokenPrincipal
|
||||
|
||||
_ENC_KEY = "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA="
|
||||
settings = Settings(
|
||||
allowed_origins_raw="http://localhost:3000",
|
||||
db_enabled=True,
|
||||
credential_encryption_key=_ENC_KEY,
|
||||
)
|
||||
user_principal = TokenPrincipal(
|
||||
token_id="t-user", user_id="user-1", permission="read",
|
||||
token_type="user", runtime_id="rt-1",
|
||||
)
|
||||
mock_repo = MagicMock()
|
||||
mock_repo.get_token_principal.return_value = user_principal
|
||||
|
||||
with patch("app.core.auth.get_portfolio_repository_from_settings", return_value=mock_repo), \
|
||||
patch("app.api.v1_assets.get_portfolio_repository_from_settings", return_value=mock_repo):
|
||||
app = create_app(settings_factory=lambda: settings)
|
||||
app.dependency_overrides[get_settings] = lambda: settings
|
||||
client = TestClient(app)
|
||||
resp = client.post(
|
||||
"/v1/assets",
|
||||
json={"symbol": "005930", "markets": ["KRX"]},
|
||||
headers={"Authorization": "Bearer user-token"},
|
||||
)
|
||||
|
||||
assert resp.status_code == 403
|
||||
|
||||
|
||||
# ===========================================================================
|
||||
# REQ-012: Portfolio create catalog validation
|
||||
# ===========================================================================
|
||||
|
||||
class _PortfolioServiceFakeRepo:
|
||||
"""FakeRepo for PortfolioService catalog validation tests."""
|
||||
|
||||
def __init__(self, asset: Asset | None = None) -> None:
|
||||
self._asset = asset
|
||||
self._strategy_sets: dict = {}
|
||||
self._portfolios: dict = {}
|
||||
|
||||
def get_asset_by_id(self, asset_id: str) -> Asset | None:
|
||||
if self._asset and self._asset.asset_id == asset_id:
|
||||
return self._asset
|
||||
return None
|
||||
|
||||
def get_asset_by_symbol(self, symbol: str) -> Asset | None:
|
||||
if self._asset and self._asset.symbol == symbol:
|
||||
return self._asset
|
||||
return None
|
||||
|
||||
def get_or_create_strategy_set(self, name: str, config: str):
|
||||
from app.domain.models import StrategySet
|
||||
key = f"{name}:{config}"
|
||||
if key not in self._strategy_sets:
|
||||
self._strategy_sets[key] = StrategySet(id=f"ss-{len(self._strategy_sets)}", name=name, config=config, nick=name)
|
||||
return self._strategy_sets[key]
|
||||
|
||||
def create_portfolio(self, portfolio_id: str, *, name, owner_user_id, broker, status, asset_id, **kwargs):
|
||||
from app.domain.models import Portfolio
|
||||
portfolio = Portfolio(
|
||||
portfolio_id=portfolio_id, broker=broker, status=status, name=name,
|
||||
symbol=asset_id, asset_id=asset_id, owner_user_id=owner_user_id,
|
||||
cash_balance=kwargs.get("cash_balance", 0.0),
|
||||
asset_quantity=kwargs.get("asset_quantity", 0.0),
|
||||
price=kwargs.get("asset_price", 0.0),
|
||||
profit_buffer=kwargs.get("profit_buffer", 0.0),
|
||||
active_strategy_id=kwargs.get("active_strategy_id"),
|
||||
)
|
||||
self._portfolios[portfolio_id] = portfolio
|
||||
return portfolio
|
||||
|
||||
def get(self, portfolio_id: str):
|
||||
p = self._portfolios.get(portfolio_id)
|
||||
if p is None:
|
||||
raise ValueError(f"portfolio not found: {portfolio_id}")
|
||||
return p
|
||||
|
||||
def get_strategy_set(self, id: str):
|
||||
return None
|
||||
|
||||
def list_recent_trades(self, portfolio_id: str, *, limit: int = 5):
|
||||
return []
|
||||
|
||||
def list_comments(self, portfolio_id: str):
|
||||
return []
|
||||
|
||||
def list_strategy_sets(self):
|
||||
return []
|
||||
|
||||
def list_portfolios(self, **kwargs):
|
||||
return []
|
||||
|
||||
def list_ledger_entries(self, portfolio_id: str, **kwargs):
|
||||
return []
|
||||
|
||||
def list_broker_credentials(self, **kwargs):
|
||||
return []
|
||||
|
||||
|
||||
_CATALOG_ASSET_ID = "aaaaaaaa-0000-0000-0000-000000000001"
|
||||
|
||||
|
||||
def _active_asset() -> Asset:
|
||||
return Asset(asset_id=_CATALOG_ASSET_ID, symbol="005930", markets=["KRX"], status="active")
|
||||
|
||||
|
||||
def _inactive_asset() -> Asset:
|
||||
return Asset(asset_id=_CATALOG_ASSET_ID, symbol="005930", markets=["KRX"], status="inactive")
|
||||
|
||||
|
||||
# REQ-012 AC-1: active asset → portfolio create succeeds
|
||||
def test_portfolio_create_with_active_asset() -> None:
|
||||
from app.services.portfolio_service import PortfolioService
|
||||
from app.schemas.portfolio import CreatePortfolioRequest
|
||||
|
||||
repo = _PortfolioServiceFakeRepo(asset=_active_asset())
|
||||
service = PortfolioService(repo)
|
||||
result = service.create_portfolio(
|
||||
CreatePortfolioRequest(
|
||||
name="Test_Portfolio",
|
||||
asset_id=_CATALOG_ASSET_ID,
|
||||
broker="kis",
|
||||
),
|
||||
owner_user_id="user-1",
|
||||
)
|
||||
assert result is not None
|
||||
|
||||
|
||||
# REQ-012 AC-2: unknown asset_id → "asset not found" error
|
||||
def test_portfolio_create_unknown_asset() -> None:
|
||||
from app.services.portfolio_service import PortfolioService
|
||||
from app.schemas.portfolio import CreatePortfolioRequest
|
||||
|
||||
repo = _PortfolioServiceFakeRepo(asset=None)
|
||||
service = PortfolioService(repo)
|
||||
with pytest.raises(ValueError, match="asset not found"):
|
||||
service.create_portfolio(
|
||||
CreatePortfolioRequest(
|
||||
name="Test_Portfolio",
|
||||
asset_id="nonexistent-uuid",
|
||||
broker="kis",
|
||||
),
|
||||
owner_user_id="user-1",
|
||||
)
|
||||
|
||||
|
||||
# REQ-012 AC-3: inactive asset → "asset is inactive" error
|
||||
def test_portfolio_create_inactive_asset() -> None:
|
||||
from app.services.portfolio_service import PortfolioService
|
||||
from app.schemas.portfolio import CreatePortfolioRequest
|
||||
|
||||
repo = _PortfolioServiceFakeRepo(asset=_inactive_asset())
|
||||
service = PortfolioService(repo)
|
||||
with pytest.raises(ValueError, match="asset is inactive"):
|
||||
service.create_portfolio(
|
||||
CreatePortfolioRequest(
|
||||
name="Test_Portfolio",
|
||||
asset_id=_CATALOG_ASSET_ID,
|
||||
broker="kis",
|
||||
),
|
||||
owner_user_id="user-1",
|
||||
)
|
||||
|
||||
|
||||
# REQ-012 AC-4: --symbol resolves asset_id and creates portfolio
|
||||
def test_portfolio_create_by_symbol() -> None:
|
||||
from typer.testing import CliRunner
|
||||
from app.cli.main import create_app
|
||||
from app.core.config import Settings
|
||||
from app.domain.models import User, StrategySet
|
||||
|
||||
class _FullFakeRepo(_PortfolioServiceFakeRepo):
|
||||
def __init__(self):
|
||||
super().__init__(asset=_active_asset())
|
||||
self._users = {"user-1": User(id="user-1", username="alice", permission="read", is_active=True)}
|
||||
self._users_by_username = {"alice": self._users["user-1"]}
|
||||
|
||||
def get_user_by_username(self, username: str):
|
||||
return self._users_by_username.get(username)
|
||||
|
||||
def get_portfolio_by_name_and_user(self, owner_user_id: str, name: str):
|
||||
return next(
|
||||
(p for p in self._portfolios.values()
|
||||
if p.owner_user_id == owner_user_id and p.name == name),
|
||||
None,
|
||||
)
|
||||
|
||||
repo = _FullFakeRepo()
|
||||
settings = Settings(allowed_origins_raw="http://localhost:3000")
|
||||
app = create_app(
|
||||
settings_factory=lambda: settings,
|
||||
repository_factory=lambda _: repo,
|
||||
)
|
||||
runner = CliRunner()
|
||||
result = runner.invoke(app, [
|
||||
"portfolio", "create", "Test_Portfolio",
|
||||
"--user", "alice",
|
||||
"--symbol", "005930",
|
||||
"--force",
|
||||
])
|
||||
assert result.exit_code == 0, result.output
|
||||
assert len(repo._portfolios) == 1
|
||||
assert list(repo._portfolios.values())[0].asset_id == _CATALOG_ASSET_ID
|
||||
|
||||
Reference in New Issue
Block a user