feat: REQ-001~018 Implemented 전환, REQ-010 GET /v1/assets admin catalog 재정의, REL-001 draft
- confirm-req-implemented: REQ-001~018 (17건, REQ-013 제외) Approved → Implemented - BAT-001(REQ-009/011/014), BAT-002(REQ-010/012/015), BAT-003(REQ-001/002/003/006) - BAT-004(REQ-004/005), BAT-005(REQ-007/008), BAT-006(REQ-016/017/018) - CHG-20260521-01 entry 각 REQ에 추가; SRS index Recent Change Log 갱신 - REQ-010 CHG-20260521-02: GET /v1/assets admin catalog 전용 재정의 - 기존 token_type 분기 portfolio 조회 코드 제거, admin permission + list_assets() 호출로 대체 - AssetCatalogListResponse 스키마 추가 (items/total) - REQ-010 Status: Implemented → Approved (재검증 필요) - 테스트 343건 전체 통과: service/user token 403, admin token 200 + catalog schema 검증 - migration 보강: portfolios_asset_migration market 컬럼 부재 fallback, portfolio_tags 빈 테이블 early-return, service_token index fix autocommit_block 정리 - docs/releases/rel-001: REL-001 draft 추가 (BAT-001~011 포함) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -31,20 +31,31 @@ def upgrade() -> None:
|
||||
inspector = inspect(bind)
|
||||
|
||||
# Step 1: Populate assets catalog from existing portfolios (REQ-014)
|
||||
# Only if portfolios.symbol column still exists (idempotent guard)
|
||||
# Only if portfolios.symbol column still exists (idempotent guard).
|
||||
# portfolios.market 컬럼은 이전 BAT-008 migration(20260502_0014) 또는
|
||||
# ensure_schema() 경로에 따라 존재하지 않을 수 있다. REQ-014 본문 "market 값이
|
||||
# NULL인 기존 행은 빈 배열로 처리"에 따라 컬럼 부재 시 markets=[]로 fallback.
|
||||
if _column_exists(inspector, "portfolios", "symbol"):
|
||||
bind.execute(text("""
|
||||
INSERT INTO assets (symbol, markets)
|
||||
SELECT
|
||||
symbol,
|
||||
COALESCE(
|
||||
ARRAY_AGG(DISTINCT market) FILTER (WHERE market IS NOT NULL),
|
||||
ARRAY[]::text[]
|
||||
)
|
||||
FROM portfolios
|
||||
GROUP BY symbol
|
||||
ON CONFLICT (symbol) DO NOTHING
|
||||
"""))
|
||||
if _column_exists(inspector, "portfolios", "market"):
|
||||
bind.execute(text("""
|
||||
INSERT INTO assets (symbol, markets)
|
||||
SELECT
|
||||
symbol,
|
||||
COALESCE(
|
||||
ARRAY_AGG(DISTINCT market) FILTER (WHERE market IS NOT NULL),
|
||||
ARRAY[]::text[]
|
||||
)
|
||||
FROM portfolios
|
||||
GROUP BY symbol
|
||||
ON CONFLICT (symbol) DO NOTHING
|
||||
"""))
|
||||
else:
|
||||
bind.execute(text("""
|
||||
INSERT INTO assets (symbol, markets)
|
||||
SELECT DISTINCT symbol, ARRAY[]::text[]
|
||||
FROM portfolios
|
||||
ON CONFLICT (symbol) DO NOTHING
|
||||
"""))
|
||||
|
||||
# Step 2: Add portfolios.asset_id column (nullable, temporary)
|
||||
if not _column_exists(inspector, "portfolios", "asset_id"):
|
||||
|
||||
@@ -10,6 +10,8 @@ before running this migration in a live environment.
|
||||
|
||||
from __future__ import annotations
|
||||
|
||||
import os
|
||||
|
||||
import sqlalchemy as sa
|
||||
from alembic import op
|
||||
from sqlalchemy import inspect, text
|
||||
@@ -20,7 +22,10 @@ branch_labels = None
|
||||
depends_on = None
|
||||
|
||||
# Operator must confirm this user ID exists in the users table before running.
|
||||
MIGRATION_ADMIN_ID = "migration-admin"
|
||||
# Override via `MIGRATION_ADMIN_ID` env var (recommended for live environments
|
||||
# with existing portfolio_tags rows). Default placeholder triggers admin check
|
||||
# failure on purpose if real data is present.
|
||||
MIGRATION_ADMIN_ID = os.environ.get("MIGRATION_ADMIN_ID", "migration-admin")
|
||||
|
||||
|
||||
def _table_exists(inspector: sa.engine.Inspector, table_name: str) -> bool:
|
||||
@@ -75,6 +80,13 @@ def upgrade() -> None:
|
||||
# portfolio_tags already gone — migration was already applied or skipped
|
||||
return
|
||||
|
||||
# 빈 portfolio_tags 환경에서는 admin 검증·INSERT가 의미 없으므로 테이블만 drop.
|
||||
# 데이터가 있으면 REQ-006 본문 정책에 따라 MIGRATION_ADMIN_ID 사전 검증을 강제.
|
||||
row_count = bind.execute(text("SELECT COUNT(*) FROM portfolio_tags")).scalar() or 0
|
||||
if row_count == 0:
|
||||
bind.execute(text("DROP TABLE IF EXISTS portfolio_tags"))
|
||||
return
|
||||
|
||||
run_migration(bind, MIGRATION_ADMIN_ID)
|
||||
|
||||
|
||||
|
||||
@@ -8,7 +8,7 @@ Create Date: 2026-05-20 00:00:00
|
||||
from __future__ import annotations
|
||||
|
||||
from alembic import op
|
||||
from sqlalchemy import inspect
|
||||
from sqlalchemy import inspect, text
|
||||
|
||||
|
||||
revision = "20260520_0022"
|
||||
@@ -26,37 +26,30 @@ def upgrade() -> None:
|
||||
inspector = inspect(bind)
|
||||
|
||||
if _index_exists(inspector, "auth_tokens", "idx_auth_tokens_service_name_unique"):
|
||||
bind.execute(
|
||||
__import__("sqlalchemy").text(
|
||||
"DROP INDEX IF EXISTS idx_auth_tokens_service_name_unique"
|
||||
op.execute("DROP INDEX IF EXISTS idx_auth_tokens_service_name_unique")
|
||||
|
||||
# CREATE INDEX CONCURRENTLY는 트랜잭션 밖에서 실행해야 하므로 autocommit_block 사용.
|
||||
with op.get_context().autocommit_block():
|
||||
op.execute(
|
||||
text(
|
||||
"""
|
||||
CREATE UNIQUE INDEX CONCURRENTLY IF NOT EXISTS idx_auth_tokens_service_name_unique
|
||||
ON auth_tokens (name)
|
||||
WHERE token_type = 'service' AND revoked_at IS NULL
|
||||
"""
|
||||
)
|
||||
)
|
||||
|
||||
autocommit_bind = bind.execution_options(isolation_level="AUTOCOMMIT")
|
||||
autocommit_bind.execute(
|
||||
__import__("sqlalchemy").text(
|
||||
"""
|
||||
CREATE UNIQUE INDEX CONCURRENTLY IF NOT EXISTS idx_auth_tokens_service_name_unique
|
||||
ON auth_tokens (name)
|
||||
WHERE token_type = 'service' AND revoked_at IS NULL
|
||||
"""
|
||||
)
|
||||
)
|
||||
|
||||
|
||||
def downgrade() -> None:
|
||||
bind = op.get_bind()
|
||||
inspector = inspect(bind)
|
||||
|
||||
if _index_exists(inspector, "auth_tokens", "idx_auth_tokens_service_name_unique"):
|
||||
bind.execute(
|
||||
__import__("sqlalchemy").text(
|
||||
"DROP INDEX IF EXISTS idx_auth_tokens_service_name_unique"
|
||||
)
|
||||
)
|
||||
op.execute("DROP INDEX IF EXISTS idx_auth_tokens_service_name_unique")
|
||||
|
||||
bind.execute(
|
||||
__import__("sqlalchemy").text(
|
||||
op.execute(
|
||||
text(
|
||||
"""
|
||||
CREATE UNIQUE INDEX IF NOT EXISTS idx_auth_tokens_service_name_unique
|
||||
ON auth_tokens (name)
|
||||
|
||||
Reference in New Issue
Block a user