trex/portfolio-hub
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat: implement asset catalog database foundation (BAT-001, REQ-009/011/014)

Browse Source 
Asset Catalog Model Implementation (BAT-001):
- Introduce assets table with UUID PK, symbol UNIQUE, markets TEXT[] array
- Define MarketCode enum (KRX, NXT, SOR, NASDAQ, NYSE, UPBIT, BITHUMB)
- Add Asset domain model with catalog properties
- Implement asset CRUD protocols in portfolio_repository
- Add PostgreSQL asset CRUD operations with GIN index on markets

Portfolio Model Refactoring (REQ-011):
- Add portfolios.asset_id UUID FK to assets(asset_id) ON DELETE RESTRICT
- Remove portfolios.symbol and portfolios.market columns
- Update Portfolio domain model to reference asset_id instead of symbol/market
- Refactor all portfolio queries to JOIN assets catalog
- Update all repository methods to use asset references

Data Migration (REQ-014):
- Create 20260519_0017 Alembic revision for assets table creation
- Create 20260519_0018 Alembic revision for atomic data migration:
  * Extract unique symbol combinations from portfolios
  * Aggregate markets using ARRAY_AGG(DISTINCT market)
  * Populate assets catalog with extracted data
  * Update portfolios.asset_id to reference new assets
  * Remove legacy symbol/market columns in single transaction
- Implement migration with rollback support

Requirements Approved (REQ-001~008):
- REQ-001~008 transitioned from Proposed to Approved
- Complete tag model requirement set with implementation readiness

New Requirements Approved (REQ-009~015):
- REQ-009: assets table schema (approved, included in BAT-001)
- REQ-010: admin asset catalog CRUD (approved, future BAT-002)
- REQ-011: portfolios asset_id FK (approved, included in BAT-001)
- REQ-012: portfolio create catalog validation (approved, future BAT-002)
- REQ-013: GET /v1/assets token branching (approved, future BAT-002)
- REQ-014: portfolios data migration (approved, included in BAT-001)
- REQ-015: asset catalog baseline docs (approved)

Code Changes:
- app/domain/models.py: Add Asset model, MarketCode enum, Portfolio asset_id FK
- app/repositories/portfolio_repository.py: Define asset CRUD protocol
- app/repositories/postgres.py: Implement asset operations with full CRUD
- app/api/v1_assets.py: Remove symbol/market direct references
- app/cli/commands/portfolio.py: Update portfolio commands for asset references
- app/schemas/portfolio.py: Update portfolio schema with asset_id
- All portfolio operations throughout codebase: Use asset references

Testing:
- Add test_asset_catalog.py for asset CRUD operations
- Verify REQ-009 AC-1~5 (asset catalog creation, lookup, uniqueness)
- Verify REQ-011 AC-1~5 (FK constraint, portfolio asset reference)
- Verify REQ-014 AC-1~6 (migration atomicity, data correctness, rollback)
- Update existing tests for asset model usage

Documentation:
- Create BAT-001 batch documents (planning, design, implementation, verification)
- Update dcy-001 with implementation details and confirmed architecture
- Add 8 new requirement documents (REQ-009~015)
- Update docs/discovery/index.md with batch entry

Impact:
- Database: assets catalog table, portfolios refactored to reference assets
- Migration: 2 new Alembic revisions (0017 assets, 0018 portfolio migration)
- API: Symbol/market now accessed through asset references
- CLI: Portfolio commands require asset reference pattern
- All existing portfolio data preserved and correctly migrated
This commit is contained in:
genichin
2026-05-19 15:59:20 +00:00
parent 1082f041a1
commit e2226e28b6
40 changed files with 2118 additions and 168 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/test_portfolio_uuid.py
+34 -15
View File
@@ -78,7 +78,7 @@ class FakeRepo:
owner_user_id: str,
broker: str,
status: str,
symbol: str,
asset_id: str,
cash_balance: float,
asset_quantity: float,
asset_price: float,
@@ -96,7 +96,8 @@ class FakeRepo:
broker=broker,
status=status,
name=name,
symbol=symbol,
symbol=asset_id,
asset_id=asset_id,
owner_user_id=owner_user_id,
cash_balance=cash_balance,
asset_quantity=asset_quantity,
@@ -108,6 +109,21 @@ class FakeRepo:
self._portfolios.append(portfolio)
return portfolio
def get_asset_by_id(self, asset_id: str):
return None
def get_asset_by_symbol(self, symbol: str):
return None
def list_assets(self):
return []
def insert_asset(self, *, symbol: str, markets, display_name=None, status: str = "active"):
return None
def update_asset(self, asset_id: str, **kwargs):
return None
def get_portfolio_by_name_and_user(self, owner_user_id: str, name: str) -> Portfolio | None:
return next(
(p for p in self._portfolios if p.owner_user_id == owner_user_id and p.name == name),
@@ -311,6 +327,9 @@ class FakeRepo:
del self._comments[comment_id]
_TEST_ASSET_ID = "00000000-0000-0000-0000-000000000001"
def _settings() -> Settings:
return Settings(db_enabled=True, allowed_origins_raw="http://localhost:3000")
@@ -331,7 +350,7 @@ def test_create_portfolio_assigns_uuid_id() -> None:
result = runner.invoke(
runner.app,
["portfolio", "create", "SAMSUNG", "--symbol", "005930", "--user", "alice", "--force"],
["portfolio", "create", "SAMSUNG", "--asset-id", _TEST_ASSET_ID, "--user", "alice", "--force"],
)
assert result.exit_code == 0, result.output
@@ -352,7 +371,7 @@ def test_create_returns_uuid_in_response() -> None:
result = runner.invoke(
runner.app,
["--format", "json", "portfolio", "create", "MY_PORTFOLIO", "--symbol", "005930", "--user", "alice", "--force"],
["--format", "json", "portfolio", "create", "MY_PORTFOLIO", "--asset-id", _TEST_ASSET_ID, "--user", "alice", "--force"],
)
assert result.exit_code == 0, result.output
@@ -370,7 +389,7 @@ def test_status_resolves_by_name_and_user() -> None:
create_result = runner.invoke(
runner.app,
["--format", "json", "portfolio", "create", "MY_PORT", "--symbol", "005930", "--user", "alice", "--force"],
["--format", "json", "portfolio", "create", "MY_PORT", "--asset-id", _TEST_ASSET_ID, "--user", "alice", "--force"],
)
assert create_result.exit_code == 0, create_result.output
@@ -418,7 +437,7 @@ def test_create_without_user_fails() -> None:
result = runner.invoke(
runner.app,
["portfolio", "create", "MY_PORT", "--symbol", "005930", "--force"],
["portfolio", "create", "MY_PORT", "--asset-id", _TEST_ASSET_ID, "--force"],
)
assert result.exit_code != 0
@@ -431,7 +450,7 @@ def test_create_with_unknown_user_fails() -> None:
result = runner.invoke(
runner.app,
["portfolio", "create", "MY_PORT", "--symbol", "005930", "--user", "ghost", "--force"],
["portfolio", "create", "MY_PORT", "--asset-id", _TEST_ASSET_ID, "--user", "ghost", "--force"],
)
assert result.exit_code == 1
@@ -445,7 +464,7 @@ def test_name_validation_rejects_invalid_characters() -> None:
result = runner.invoke(
runner.app,
["portfolio", "create", "invalid name!", "--symbol", "005930", "--user", "alice", "--force"],
["portfolio", "create", "invalid name!", "--asset-id", _TEST_ASSET_ID, "--user", "alice", "--force"],
)
assert result.exit_code == 1
@@ -459,7 +478,7 @@ def test_name_validation_rejects_empty_name() -> None:
result = runner.invoke(
runner.app,
["portfolio", "create", "", "--symbol", "005930", "--user", "alice", "--force"],
["portfolio", "create", "", "--asset-id", _TEST_ASSET_ID, "--user", "alice", "--force"],
)
assert result.exit_code != 0
@@ -473,11 +492,11 @@ def test_alice_and_bob_can_have_same_portfolio_name() -> None:
alice_result = runner.invoke(
runner.app,
["portfolio", "create", "SAMSUNG", "--symbol", "005930", "--user", "alice", "--force"],
["portfolio", "create", "SAMSUNG", "--asset-id", _TEST_ASSET_ID, "--user", "alice", "--force"],
)
bob_result = runner.invoke(
runner.app,
["portfolio", "create", "SAMSUNG", "--symbol", "005930", "--user", "bob", "--force"],
["portfolio", "create", "SAMSUNG", "--asset-id", _TEST_ASSET_ID, "--user", "bob", "--force"],
)
assert alice_result.exit_code == 0, alice_result.output
@@ -494,7 +513,7 @@ def test_buy_resolves_portfolio_by_name_and_user() -> None:
runner.invoke(
runner.app,
["portfolio", "create", "MY_PORT", "--symbol", "005930", "--cash-balance", "1000000", "--user", "alice", "--force"],
["portfolio", "create", "MY_PORT", "--asset-id", _TEST_ASSET_ID, "--cash-balance", "1000000", "--user", "alice", "--force"],
)
buy_result = runner.invoke(
runner.app,
@@ -513,7 +532,7 @@ def test_delete_resolves_portfolio_by_name_and_user() -> None:
runner.invoke(
runner.app,
["portfolio", "create", "MY_PORT", "--symbol", "005930", "--user", "alice", "--force"],
["portfolio", "create", "MY_PORT", "--asset-id", _TEST_ASSET_ID, "--user", "alice", "--force"],
)
delete_result = runner.invoke(
runner.app,
@@ -533,7 +552,7 @@ def test_alice_cannot_delete_bobs_portfolio() -> None:
runner.invoke(
runner.app,
["portfolio", "create", "SAMSUNG", "--symbol", "005930", "--user", "bob", "--force"],
["portfolio", "create", "SAMSUNG", "--asset-id", _TEST_ASSET_ID, "--user", "bob", "--force"],
)
delete_result = runner.invoke(
runner.app,
@@ -551,7 +570,7 @@ def test_update_new_name_renames_portfolio() -> None:
runner.invoke(
runner.app,
["portfolio", "create", "OLD_NAME", "--symbol", "005930", "--user", "alice", "--force"],
["portfolio", "create", "OLD_NAME", "--asset-id", _TEST_ASSET_ID, "--user", "alice", "--force"],
)
rename_result = runner.invoke(
runner.app,