Asset Catalog Model Implementation (BAT-001): - Introduce assets table with UUID PK, symbol UNIQUE, markets TEXT[] array - Define MarketCode enum (KRX, NXT, SOR, NASDAQ, NYSE, UPBIT, BITHUMB) - Add Asset domain model with catalog properties - Implement asset CRUD protocols in portfolio_repository - Add PostgreSQL asset CRUD operations with GIN index on markets Portfolio Model Refactoring (REQ-011): - Add portfolios.asset_id UUID FK to assets(asset_id) ON DELETE RESTRICT - Remove portfolios.symbol and portfolios.market columns - Update Portfolio domain model to reference asset_id instead of symbol/market - Refactor all portfolio queries to JOIN assets catalog - Update all repository methods to use asset references Data Migration (REQ-014): - Create 20260519_0017 Alembic revision for assets table creation - Create 20260519_0018 Alembic revision for atomic data migration: * Extract unique symbol combinations from portfolios * Aggregate markets using ARRAY_AGG(DISTINCT market) * Populate assets catalog with extracted data * Update portfolios.asset_id to reference new assets * Remove legacy symbol/market columns in single transaction - Implement migration with rollback support Requirements Approved (REQ-001~008): - REQ-001~008 transitioned from Proposed to Approved - Complete tag model requirement set with implementation readiness New Requirements Approved (REQ-009~015): - REQ-009: assets table schema (approved, included in BAT-001) - REQ-010: admin asset catalog CRUD (approved, future BAT-002) - REQ-011: portfolios asset_id FK (approved, included in BAT-001) - REQ-012: portfolio create catalog validation (approved, future BAT-002) - REQ-013: GET /v1/assets token branching (approved, future BAT-002) - REQ-014: portfolios data migration (approved, included in BAT-001) - REQ-015: asset catalog baseline docs (approved) Code Changes: - app/domain/models.py: Add Asset model, MarketCode enum, Portfolio asset_id FK - app/repositories/portfolio_repository.py: Define asset CRUD protocol - app/repositories/postgres.py: Implement asset operations with full CRUD - app/api/v1_assets.py: Remove symbol/market direct references - app/cli/commands/portfolio.py: Update portfolio commands for asset references - app/schemas/portfolio.py: Update portfolio schema with asset_id - All portfolio operations throughout codebase: Use asset references Testing: - Add test_asset_catalog.py for asset CRUD operations - Verify REQ-009 AC-1~5 (asset catalog creation, lookup, uniqueness) - Verify REQ-011 AC-1~5 (FK constraint, portfolio asset reference) - Verify REQ-014 AC-1~6 (migration atomicity, data correctness, rollback) - Update existing tests for asset model usage Documentation: - Create BAT-001 batch documents (planning, design, implementation, verification) - Update dcy-001 with implementation details and confirmed architecture - Add 8 new requirement documents (REQ-009~015) - Update docs/discovery/index.md with batch entry Impact: - Database: assets catalog table, portfolios refactored to reference assets - Migration: 2 new Alembic revisions (0017 assets, 0018 portfolio migration) - API: Symbol/market now accessed through asset references - CLI: Portfolio commands require asset reference pattern - All existing portfolio data preserved and correctly migrated
5.2 KiB
5.2 KiB
REQ-013: GET /v1/assets 토큰 타입별 분기 재정의
- Status: Approved
- Type: Interface
- Priority: High
- Owner: Justin Ko
Intent
- 현재 service token(daemon) 전용으로 구현된
GET /v1/assets를 user token 및 admin token도 지원하는 통합 portfolio 조회 엔드포인트로 재정의한다. - daemon(service token), 로그인 사용자(user token), 관리자(admin token) 모두 단일 엔드포인트로 각자의 portfolio 목록을 조회할 수 있도록 한다.
Requirement
GET /v1/assets엔드포인트를 토큰 타입에 따라 아래와 같이 분기한다.- service token (daemon): auth context에서
daemon_id를 자동 추출,managed_by_daemon_id = auth.daemon_id필터링.daemon_id가 없으면 HTTP 403. - user token:
owner_user_id = auth.user_id필터링. 본인 portfolio만 반환. - admin token: 기본
owner_user_id = auth.user_id(본인 portfolio).?user_id=<id>파라미터 지정 시 해당 user의 portfolio 반환.
- service token (daemon): auth context에서
- 모든 토큰 타입에서
?market=<code>파라미터를 지원한다. 지정 시<code> = ANY(assets.markets)인 portfolio만 반환한다. - 응답 항목의
asset_id는 catalog의assets.asset_id(UUID)를 참조한다(현재portfolio.portfolio_id가 아님). app/api/v1_assets.py의list_assets함수를 토큰 타입 분기 로직으로 재작성한다. 현재_require_service_token강제를 제거하고 토큰 타입 자동 분기로 교체한다.
Acceptance Criteria
- Given daemon service token(daemon_id 있음), When
GET /v1/assets, Thenmanaged_by_daemon_id = auth.daemon_id로 필터링된 portfolio 목록이 반환된다. - Given daemon service token(daemon_id 없음), When
GET /v1/assets, Then HTTP 403이 반환된다. - Given user token, When
GET /v1/assets, Thenowner_user_id = auth.user_id인 portfolio 목록만 반환된다. - Given admin token, When
GET /v1/assets(?user_id없음), Then admin 본인의 portfolio 목록이 반환된다. - Given admin token, When
GET /v1/assets?user_id=<target_user_id>, Then 해당 user의 portfolio 목록이 반환된다. - Given 모든 토큰 타입, When
GET /v1/assets?market=KRX, ThenKRX = ANY(assets.markets)인 portfolio만 반환된다. - Given 응답 항목, When
asset_id필드 확인, Thenassets.asset_id(catalog UUID)를 참조한다(portfolio_id가 아님).
Impacted Area
- Docs:
- docs/runtime-flows.md — "GET /v1/assets" 플로우 재정의 (REQ-015에서 처리). 현재 기술(service-token-only, daemon-id guard)을 토큰 타입 분기 구조로 교체.
- docs/interface-contract.md — GET /v1/assets 명세 갱신 (REQ-015에서 처리)
- Modules:
app/api/v1_assets.py—list_assets토큰 타입 분기 재작성,?user_id파라미터 추가,_require_service_token강제 제거app/repositories/postgres.py— token-type별 portfolios 쿼리 분기
- Tests:
tests/test_v1_asset_catalog.py(신규) — AC-1~7 검증- 기존
test_v1_assets.py또는 관련 테스트 — service token 전용 동작 갱신
Notes
- 현재
app/api/v1_assets.py의_require_service_token은 service token 전용으로 구현되어 있다. 이 REQ는 해당 guard를 제거하고 토큰 타입 자동 분기로 완전 재작성하는 작업이다. - 현재
runtime-flows.md"Flow: v1 API — GET /v1/assets"는 service-token-only 구조를 기술하고 있다. 이 REQ 구현 후 해당 플로우를 REQ-015에서 갱신해야 한다. - REQ-009(assets 테이블), REQ-011(portfolios 재설계) 선행 필요.
- Source: dcy-001 FR-5
Change Log
CHG-20260519-02
- Date: 2026-05-19
- Author: Justin Ko
Change Summary
- Status: Proposed → Approved
Intent
- 승인 게이트 통과: 필수 필드(Status/Type/Priority/Owner/Intent/Requirement/AC/Impacted Area/Change Log) 모두 충족, AC 구체성 확인 완료
Acceptance Criteria Delta
- No change
Impacted Area Delta
- No change
Delivery Trace Delta
- Batches:
- none (미정)
- Releases:
- none (미정)
Revalidation Impact
- Reverification Needed: no
- Existing Implementation Invalidated: no
- Status Recommendation: promote-to-approved
- Follow-up Action: batch 계획 편입
CHG-20260519-01
- Date: 2026-05-19
- Author: Justin Ko
Change Summary
- 최초 생성 — dcy-001 confirm-discovery 후 draft-req 실행
Intent
- dcy-001 FR-5를 Interface REQ로 분리; GET /v1/assets 토큰 타입별 분기 정의
Acceptance Criteria Delta
- Added:
- AC-1~7 최초 작성
Impacted Area Delta
- Docs:
- docs/runtime-flows.md, docs/interface-contract.md — 최초 지정
- Modules:
- app/api/v1_assets.py, app/repositories/postgres.py — 최초 지정
- Tests:
- tests/test_v1_asset_catalog.py (신규), 기존 v1 테스트 — 최초 지정
Delivery Trace Delta
- Batches:
- none (미정)
- Releases:
- none (미정)
Revalidation Impact
- Reverification Needed: no
- Existing Implementation Invalidated: no
- Status Recommendation: keep-current
- Follow-up Action: confirm-req 후 batch 계획 편입; REQ-009, REQ-011 선행 의존성 확인
Validation Plan
- pytest TestClient로 AC-1~7 검증; 토큰 타입별 시나리오를 각각 독립 테스트로 분리