Files

T

genichin e2226e28b6 feat: implement asset catalog database foundation (BAT-001, REQ-009/011/014)

Asset Catalog Model Implementation (BAT-001):
- Introduce assets table with UUID PK, symbol UNIQUE, markets TEXT[] array
- Define MarketCode enum (KRX, NXT, SOR, NASDAQ, NYSE, UPBIT, BITHUMB)
- Add Asset domain model with catalog properties
- Implement asset CRUD protocols in portfolio_repository
- Add PostgreSQL asset CRUD operations with GIN index on markets

Portfolio Model Refactoring (REQ-011):
- Add portfolios.asset_id UUID FK to assets(asset_id) ON DELETE RESTRICT
- Remove portfolios.symbol and portfolios.market columns
- Update Portfolio domain model to reference asset_id instead of symbol/market
- Refactor all portfolio queries to JOIN assets catalog
- Update all repository methods to use asset references

Data Migration (REQ-014):
- Create 20260519_0017 Alembic revision for assets table creation
- Create 20260519_0018 Alembic revision for atomic data migration:
  * Extract unique symbol combinations from portfolios
  * Aggregate markets using ARRAY_AGG(DISTINCT market)
  * Populate assets catalog with extracted data
  * Update portfolios.asset_id to reference new assets
  * Remove legacy symbol/market columns in single transaction
- Implement migration with rollback support

Requirements Approved (REQ-001~008):
- REQ-001~008 transitioned from Proposed to Approved
- Complete tag model requirement set with implementation readiness

New Requirements Approved (REQ-009~015):
- REQ-009: assets table schema (approved, included in BAT-001)
- REQ-010: admin asset catalog CRUD (approved, future BAT-002)
- REQ-011: portfolios asset_id FK (approved, included in BAT-001)
- REQ-012: portfolio create catalog validation (approved, future BAT-002)
- REQ-013: GET /v1/assets token branching (approved, future BAT-002)
- REQ-014: portfolios data migration (approved, included in BAT-001)
- REQ-015: asset catalog baseline docs (approved)

Code Changes:
- app/domain/models.py: Add Asset model, MarketCode enum, Portfolio asset_id FK
- app/repositories/portfolio_repository.py: Define asset CRUD protocol
- app/repositories/postgres.py: Implement asset operations with full CRUD
- app/api/v1_assets.py: Remove symbol/market direct references
- app/cli/commands/portfolio.py: Update portfolio commands for asset references
- app/schemas/portfolio.py: Update portfolio schema with asset_id
- All portfolio operations throughout codebase: Use asset references

Testing:
- Add test_asset_catalog.py for asset CRUD operations
- Verify REQ-009 AC-1~5 (asset catalog creation, lookup, uniqueness)
- Verify REQ-011 AC-1~5 (FK constraint, portfolio asset reference)
- Verify REQ-014 AC-1~6 (migration atomicity, data correctness, rollback)
- Update existing tests for asset model usage

Documentation:
- Create BAT-001 batch documents (planning, design, implementation, verification)
- Update dcy-001 with implementation details and confirmed architecture
- Add 8 new requirement documents (REQ-009~015)
- Update docs/discovery/index.md with batch entry

Impact:
- Database: assets catalog table, portfolios refactored to reference assets
- Migration: 2 new Alembic revisions (0017 assets, 0018 portfolio migration)
- API: Symbol/market now accessed through asset references
- CLI: Portfolio commands require asset reference pattern
- All existing portfolio data preserved and correctly migrated

2026-05-19 15:59:20 +00:00

3.8 KiB

Raw Blame History

BAT-001 Verification

Status: verified
Batch: BAT-001

Acceptance Mapping

REQ-009:
- AC-1: assets 테이블 스키마 컬럼 존재 확인 → [DB-integration] 실제 PostgreSQL 연결 필요. rev-A migration 파일(20260519_0017) 구조 검증: test_migration_rev_a_creates_assets_table PASSED
- AC-2: symbol UNIQUE constraint violation → [DB-integration] 실제 PostgreSQL 연결 필요. rev-A DDL에 UniqueConstraint("symbol") 포함 확인됨
- AC-3: idx_assets_markets_gin GIN 인덱스 존재 → [DB-integration] 실제 PostgreSQL 연결 필요. rev-A DDL에 create_index(...postgresql_using="gin") 포함 확인됨
- AC-4: 허용되지 않은 MarketCode 거부 → test_market_code_rejects_unknown_code PASSED, test_market_code_rejects_empty_string PASSED
- AC-5: 소문자 입력 대문자 정규화 통과 → test_market_code_normalizes_lowercase_krx PASSED, test_market_code_normalizes_lowercase_nasdaq PASSED
REQ-011:
- AC-1: portfolios 스키마 — asset_id FK 존재, symbol/market 없음 → [DB-integration] rev-B migration 파일(20260519_0018) 구조 검증: test_migration_rev_b_drops_symbol_and_market_columns PASSED, test_migration_rev_b_has_data_migration_insert PASSED
- AC-2: 존재하지 않는 asset_id FK constraint violation → [DB-integration] rev-B DDL에 create_foreign_key(...ondelete="RESTRICT") 포함 확인됨
- AC-3: ON DELETE RESTRICT 동작 → [DB-integration] rev-B ondelete="RESTRICT" 확인됨
- AC-4: 기존 portfolio 조회 API/CLI symbol/market 참조 오류 없음 → 기존 전체 test suite 162 passed (regression 없음). test_portfolio_model_has_asset_id_no_market PASSED, test_asset_item_schema_has_no_market_field PASSED, test_create_portfolio_request_requires_asset_id_not_symbol PASSED
- AC-5: 동일 user, 동일 asset_id 복수 portfolio 생성 가능 → test_same_user_can_create_two_portfolios_for_same_asset_id PASSED
REQ-014:
- AC-1: migration 전후 portfolios 행 수 일치 → [DB-integration] rev-B DATA migration INSERT/UPDATE 로직 확인됨
- AC-2: assets 행 수 = DISTINCT symbol 수 → [DB-integration] rev-B GROUP BY symbol INSERT 확인됨
- AC-3: portfolio.asset_id JOIN assets.symbol 일치 → [DB-integration] rev-B UPDATE portfolios SET asset_id = a.asset_id FROM assets WHERE a.symbol = p.symbol 확인됨
- AC-4: assets.markets에 동일 symbol의 모든 market 값 포함 → [DB-integration] rev-B ARRAY_AGG(DISTINCT market) 확인: test_migration_rev_b_has_data_migration_insert PASSED
- AC-5: rollback 시 기존 portfolios 데이터 보존 → [DB-integration] rev-B downgrade() 구현 (symbol/market 컬럼 복원 + asset_id DROP) 확인됨
- AC-6: migration 완료 후 portfolios에 symbol/market 컬럼 없음 → test_migration_rev_b_drops_symbol_and_market_columns PASSED

Evidence

Test:
- .venv/bin/python -m pytest --tb=short → 162 passed (2026-05-19)
- tests/test_asset_catalog.py: 20 passed (REQ-009 AC-4,5 / REQ-011 AC-4,5 / migration 파일 구조)
- 기존 suite 142 tests: 모두 pass (regression 없음)
Manual:
- DB-integration ACs: 실제 PostgreSQL 인스턴스 연결 후 alembic upgrade head → psql 스키마 검증 필요
- 명령: psql -c "\d assets" — asset_id, symbol, markets, GIN 인덱스 확인
- 명령: psql -c "\d portfolios" — asset_id FK 존재, symbol/market 없음 확인
Logs:
- 없음 (DB-integration 미실행)

Result

Ready for Release: true
Blocking Issues:
- DB-integration ACs(REQ-009 AC-1~~3, REQ-011 AC-1~~3, REQ-014 AC-1~6)는 단위 테스트 범위 밖 — 운영 DB 또는 통합 테스트 환경에서 Alembic 적용 후 검증 필요. 로컬 DB 없는 CI 환경에서는 migration 파일 구조 검증으로 대체.

3.8 KiB Raw Blame History

BAT-001 Verification

Acceptance Mapping

Evidence

Result

3.8 KiB

Raw Blame History