fix(reconcile): symbol을 슬롯 생성 시 함께 저장 + NULL 슬롯 backfill

reconcile_universe 시그니처를 set[str] → dict[str, str] (portfolio_id→symbol)로 변경.
기존 symbol=NULL 슬롯은 다음 reconcile 실행 시 자동 backfill.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
2026-06-11 21:08:46 +09:00
co-authored by Claude Sonnet 4.6
parent 221a16342e
commit 24a6017457
29 changed files with 92 additions and 68 deletions
@@ -24,7 +24,7 @@ def service(repo):
def _seed(repo):
repo.reconcile_universe(INST, {"PF-1"})
repo.reconcile_universe(INST, {"PF-1": "SYM"})
return repo.list_slots(INST)[0]
@@ -24,7 +24,7 @@ def service(repo):
def _inactive_slot(repo):
repo.reconcile_universe(INST, {"pf-1"})
repo.reconcile_universe(INST, {"pf-1": "SYM"})
return repo.find_slot_by_portfolio(INST, "pf-1")
+1 -1
View File
@@ -36,7 +36,7 @@ def service(repo):
def _seed(repo, n=1):
"""Create n permanent asset slots (inactive) via universe reconcile."""
repo.reconcile_universe(INST, {f"pf-{i}" for i in range(n)})
repo.reconcile_universe(INST, {f"pf-{i}": "SYM" for i in range(n)})
return sorted(repo.list_slots(INST), key=lambda s: s.portfolio_id)
+1 -1
View File
@@ -25,7 +25,7 @@ def service(repo):
def _inactive_slot(repo):
repo.reconcile_universe(INST, {"pf-1"})
repo.reconcile_universe(INST, {"pf-1": "SYM"})
return repo.find_slot_by_portfolio(INST, "pf-1")
+11 -11
View File
@@ -15,17 +15,17 @@ def repo():
def test_creates_asset_slots_idempotently(repo):
r1 = repo.reconcile_universe(INST, {"pf-a", "pf-b"})
r1 = repo.reconcile_universe(INST, {"pf-a": "SYM", "pf-b": "SYM"})
assert r1["created"] == 2
# idempotent — second pass creates nothing
r2 = repo.reconcile_universe(INST, {"pf-a", "pf-b"})
r2 = repo.reconcile_universe(INST, {"pf-a": "SYM", "pf-b": "SYM"})
assert r2["created"] == 0
assert repo.find_slot_by_portfolio(INST, "pf-a").status is SlotState.INACTIVE
def test_soft_retire_inactive_asset_that_left_universe(repo):
repo.reconcile_universe(INST, {"pf-a", "pf-b"})
r = repo.reconcile_universe(INST, {"pf-a"}) # pf-b left
repo.reconcile_universe(INST, {"pf-a": "SYM", "pf-b": "SYM"})
r = repo.reconcile_universe(INST, {"pf-a": "SYM"}) # pf-b left
assert r["retired"] == 1
slot_b = repo.find_slot_by_portfolio(INST, "pf-b")
assert slot_b.retired_at is not None # soft-retired, row preserved
@@ -33,28 +33,28 @@ def test_soft_retire_inactive_asset_that_left_universe(repo):
def test_tombstone_holding_asset_that_left_universe(repo):
svc = SlotService(repo, instance_key=INST)
repo.reconcile_universe(INST, {"pf-a"})
repo.reconcile_universe(INST, {"pf-a": "SYM"})
slot = repo.find_slot_by_portfolio(INST, "pf-a")
svc.transit_slot(slot.slot_id, slot.status, SlotState.PENDING_BUY,
reason="r", actor="a", symbol="005930")
svc.transit_slot(slot.slot_id, SlotState.PENDING_BUY, SlotState.HOLDING,
reason="r", actor="a", avg_price=70_000)
r = repo.reconcile_universe(INST, set()) # pf-a left while holding
r = repo.reconcile_universe(INST, {}) # pf-a left while holding
assert r["tombstoned"] == 1 and r["retired"] == 0
held = repo.find_slot_by_portfolio(INST, "pf-a")
assert held.status is SlotState.HOLDING and held.retired_at is None # protected
def test_allow_retire_false_skips_retire(repo):
repo.reconcile_universe(INST, {"pf-a", "pf-b"})
r = repo.reconcile_universe(INST, {"pf-a"}, allow_retire=False)
repo.reconcile_universe(INST, {"pf-a": "SYM", "pf-b": "SYM"})
r = repo.reconcile_universe(INST, {"pf-a": "SYM"}, allow_retire=False)
assert r["retired"] == 0
assert repo.find_slot_by_portfolio(INST, "pf-b").retired_at is None
def test_count_active(repo):
svc = SlotService(repo, instance_key=INST)
repo.reconcile_universe(INST, {"pf-a", "pf-b"})
repo.reconcile_universe(INST, {"pf-a": "SYM", "pf-b": "SYM"})
assert repo.count_active(INST) == 0
slot = repo.find_slot_by_portfolio(INST, "pf-a")
svc.transit_slot(slot.slot_id, slot.status, SlotState.PENDING_BUY,
@@ -63,8 +63,8 @@ def test_count_active(repo):
def test_instance_isolation(repo):
repo.reconcile_universe("inst-1", {"pf-a"})
repo.reconcile_universe("inst-2", {"pf-a"})
repo.reconcile_universe("inst-1", {"pf-a": "SYM"})
repo.reconcile_universe("inst-2", {"pf-a": "SYM"})
# same portfolio_id, different instances -> two distinct slots
assert repo.find_slot_by_portfolio("inst-1", "pf-a").slot_id != \
repo.find_slot_by_portfolio("inst-2", "pf-a").slot_id