test: cover stale ledger outbox lease updates

Co-authored-by: genichin <4282227+genichin@users.noreply.github.com>
2026-09-12 13:27:27 +00:00
parent 09b1b4f4c3
commit 31d6e5c02b
5 changed files with 99 additions and 22 deletions
@@ -566,7 +566,8 @@ class _PgIntentRecord:
 _OUTBOX_COLUMNS = (
    "correlation_id, asset_id, order_id, execution_id, side, qty, price, "
    "fee, tax, executed_at, status, attempts, last_outcome, last_error, "
-    "created_at, updated_at, next_retry_at, venue, order_venue, instance_key"
+    "created_at, updated_at, next_retry_at, venue, order_venue, instance_key, "
+    "claim_expires_at"
 )


@@ -710,6 +711,7 @@ class PostgreSQLLedgerOutbox:
        *,
        error: Optional[str] = None,
        next_retry_at: Optional[datetime] = None,
+        expected_claim_expires_at: datetime | None = None,
    ) -> LedgerWorkItem:
        with self._psycopg.connect(self._dsn, autocommit=False) as conn:
            with conn.cursor() as cur:
@@ -731,23 +733,29 @@ class PostgreSQLLedgerOutbox:
                    attempts_delta = 1
                # next_retry_at only persists for a retryable backoff; cleared otherwise.
                nra = next_retry_at if outcome is OutboxOutcome.RETRYABLE_FAILURE else None
+                params: list[Any] = [
+                    status_value,
+                    attempts_delta,
+                    outcome.value,
+                    error,
+                    nra,
+                    self._now(),
+                    correlation_id,
+                    self._instance_key,
+                ]
+                where = "WHERE correlation_id=%s AND instance_key=%s "
+                if expected_claim_expires_at is None:
+                    where += "AND status=%s AND claim_owner IS NULL AND claim_expires_at IS NULL"
+                    params.append(WorkItemStatus.COMPLETED.value)
+                else:
+                    where += "AND claim_owner=%s AND claim_expires_at=%s"
+                    params.extend([self._worker_id, expected_claim_expires_at])
                cur.execute(
                    "UPDATE ledger_outbox SET status=%s, attempts=attempts+%s, "
                    "last_outcome=%s, last_error=%s, next_retry_at=%s, updated_at=%s, "
                    "claim_owner=NULL, claim_expires_at=NULL "
-                    "WHERE correlation_id=%s AND instance_key=%s "
-                    "AND (claim_owner=%s OR claim_owner IS NULL)",
-                    (
-                        status_value,
-                        attempts_delta,
-                        outcome.value,
-                        error,
-                        nra,
-                        self._now(),
-                        correlation_id,
-                        self._instance_key,
-                        self._worker_id,
-                    ),
+                    f"{where}",
+                    params,
                )
                conn.commit()
        row = self.get(correlation_id)
@@ -781,6 +789,7 @@ class PostgreSQLLedgerOutbox:
            updated_at=row[15],
            next_retry_at=row[16],
            instance_key=row[19],
+            claim_expires_at=row[20],
        )


@@ -13,8 +13,9 @@ WHERE instance_key IS NULL;
 ALTER TABLE ledger_outbox ALTER COLUMN instance_key SET DEFAULT '__unowned__';
 ALTER TABLE ledger_outbox ALTER COLUMN instance_key SET NOT NULL;

+DROP INDEX IF EXISTS idx_ledger_outbox_instance_pending;
 CREATE INDEX IF NOT EXISTS idx_ledger_outbox_instance_pending
-    ON ledger_outbox (instance_key, status, created_at)
+    ON ledger_outbox (instance_key, status, created_at, correlation_id)
    WHERE status = 'pending';

 CREATE INDEX IF NOT EXISTS idx_ledger_outbox_instance_claim_expires