Fix unmanaged reconciliation review blockers
Co-authored-by: genichin <4282227+genichin@users.noreply.github.com>
This commit is contained in:
co-authored by
genichin
parent
f9284d1de8
commit
591db7adb7
@@ -615,11 +615,6 @@ class InMemoryUnmanagedPositionStore:
|
||||
existing = self._states.get(key)
|
||||
previous_quantity = existing.get("quantity") if existing is not None else None
|
||||
preserved = {} if existing is None else {
|
||||
"operator_action": existing.get("operator_action"),
|
||||
"evidence_ref": existing.get("evidence_ref"),
|
||||
"operator_note": existing.get("operator_note"),
|
||||
"operator_actor": existing.get("operator_actor"),
|
||||
"operator_updated_at": existing.get("operator_updated_at"),
|
||||
"created_at": existing.get("created_at", now),
|
||||
}
|
||||
if existing is None or existing.get("lifecycle_state") == "resolved":
|
||||
|
||||
@@ -373,7 +373,7 @@ def _broker_balances_are_authoritative_for_unmanaged_resolution(broker: BrokerPo
|
||||
return False
|
||||
if isinstance(marker, bool):
|
||||
return marker
|
||||
return True
|
||||
return False
|
||||
|
||||
|
||||
def reconcile_core_holdings(
|
||||
|
||||
@@ -44,6 +44,7 @@ class SnapshotScheduler:
|
||||
read_port: PortfolioHubReadPort,
|
||||
store: SnapshotStore,
|
||||
broker: BrokerPort,
|
||||
core_holdings_broker: BrokerPort | None = None,
|
||||
schedule_kst: time = time(hour=7, minute=30),
|
||||
clock: Callable[[], datetime] | None = None,
|
||||
slot_repo=None,
|
||||
@@ -60,6 +61,7 @@ class SnapshotScheduler:
|
||||
self._read = read_port
|
||||
self._store = store
|
||||
self._broker = broker
|
||||
self._core_holdings_broker = core_holdings_broker or broker
|
||||
self._schedule_kst = schedule_kst
|
||||
self._clock = clock or (lambda: datetime.now(tz=UTC))
|
||||
self._daemon_id: str | None = None
|
||||
@@ -337,7 +339,7 @@ class SnapshotScheduler:
|
||||
# BAT-050 / REQ-103: pass warn_store for B-case durable warning.
|
||||
reconcile_core_holdings(
|
||||
slot_repo=self._slot_repo, slot_service=self._slot_service,
|
||||
broker=self._broker, instance_key=self._instance_key,
|
||||
broker=self._core_holdings_broker, instance_key=self._instance_key,
|
||||
alarm_emitter=self._alarm_emitter, # dcy-033 / REQ-100
|
||||
warn_store=self._warn_store, # BAT-050 / REQ-103
|
||||
notification_store=self._notification_store, # req-0007 / ac-0024
|
||||
|
||||
Reference in New Issue
Block a user