ledger write 응답의 portfolio-hub 권위 cash/quantity 를 스냅샷에 write-back 해
매수/매도 직후 "수량 live·현금 stale" 비대칭 제거(option D 활성화). portfolio-hub#8
(*_after 응답) 동작 중 확인으로 그간 deferred 됐던 REQ-030 을 닫음.
거버넌스: 전부 change-req (신규 REQ 없음, dcy-018 OQ-3 a).
- REQ-017: record_trade → LedgerWriteOutcome{result, cash_balance_after,
asset_quantity_after}. 어댑터가 응답 root flat *_after 파싱(new+duplicate, 누락 None)
- REQ-019: LedgerWriter 에 SnapshotStore 주입 → new+duplicate write-back
(best-effort, *_after 절대값이라 멱등). LedgerOutbox.pending_cash_delta()
- REQ-029: 추정 현금 오버레이(_apply_cash_estimate, cash_estimated 라벨, OQ-4 i)
+ 슬롯 오버레이 유지(OQ-1 B). 미정산 outbox delta 기반, write-back 수렴
- REQ-030: option D 활성화 → Approved→Implemented
best-effort 격리(NFR-1): write-back/추정 실패가 ledger 멱등·청산 무차단.
배치 번호: 동시 커밋된 BAT-022(slot-state, dcy-016)와 충돌해 BAT-023 으로 배정.
검증: 단위 350 passed/35 skipped, 인프라 게이트(PG+RabbitMQ) 385 passed, ruff clean.
신규 test_ledger_option_d + adapter/PG 테스트. BAT-023 release-candidate.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
158 lines
5.4 KiB
Python
158 lines
5.4 KiB
Python
"""Ledger outbox permanent-error + backoff + dead-letter tests (dcy-015 / issue #13).
|
|
|
|
A programmable LedgerPort raises chosen errors so we can drive: 404→permanent
|
|
terminal (no retry), retryable→backoff (next_retry_at skip), max_attempts→
|
|
dead-letter terminal, and head-of-line protection.
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
import logging
|
|
from datetime import datetime, timedelta, timezone
|
|
|
|
from trex_core.application.ledger_outbox import (
|
|
InMemoryLedgerOutbox,
|
|
LedgerWriter,
|
|
OutboxOutcome,
|
|
WorkItemStatus,
|
|
)
|
|
from trex_core.application.ledger_port import (
|
|
LedgerPermanentError,
|
|
LedgerRetryableError,
|
|
LedgerTrade,
|
|
LedgerWriteOutcome,
|
|
LedgerWriteResult,
|
|
)
|
|
|
|
UTC = timezone.utc
|
|
|
|
|
|
def _trade(cid_suffix="1", asset="PF-1") -> LedgerTrade:
|
|
return LedgerTrade(
|
|
asset_id=asset, order_id=f"O-{cid_suffix}", execution_id=f"e-{cid_suffix}",
|
|
side="buy", qty=10, price=1000.0,
|
|
executed_at=datetime(2026, 6, 4, tzinfo=UTC),
|
|
)
|
|
|
|
|
|
class _ProgrammableLedger:
|
|
"""LedgerPort double: `behavior(trade)` returns a result or raises."""
|
|
|
|
def __init__(self, behavior):
|
|
self.behavior = behavior
|
|
self.calls = 0
|
|
|
|
def record_trade(self, trade) -> LedgerWriteOutcome:
|
|
self.calls += 1
|
|
return self.behavior(trade)
|
|
|
|
|
|
def _wire(behavior, *, clock, **writer_kw):
|
|
outbox = InMemoryLedgerOutbox(clock=clock)
|
|
ledger = _ProgrammableLedger(behavior)
|
|
writer = LedgerWriter(outbox, ledger, clock=clock, rng=lambda: 0.0, **writer_kw)
|
|
return outbox, ledger, writer
|
|
|
|
|
|
def test_permanent_error_terminates_immediately_no_retry():
|
|
"""S-1: 404/permanent → delivery_failed terminal, adapter called exactly once."""
|
|
now = {"t": datetime(2026, 6, 4, tzinfo=UTC)}
|
|
|
|
def behavior(trade):
|
|
raise LedgerPermanentError("404 portfolio not registered")
|
|
|
|
outbox, ledger, writer = _wire(behavior, clock=lambda: now["t"])
|
|
outbox.enqueue(_trade())
|
|
s = writer.run_once()
|
|
assert s.delivery_failed == 1 and s.retryable == 0
|
|
[item] = outbox.all_items()
|
|
assert item.status is WorkItemStatus.DELIVERY_FAILED
|
|
assert item.last_outcome is OutboxOutcome.PERMANENT_FAILURE
|
|
# no further attempts — terminal, not pending
|
|
now["t"] += timedelta(seconds=3600)
|
|
assert writer.run_once().delivery_failed == 0
|
|
assert ledger.calls == 1 # never retried
|
|
|
|
|
|
def test_retryable_backoff_skips_until_next_retry_at():
|
|
"""S-2/S-4: a retryable row backs off and is skipped by list_pending until due."""
|
|
now = {"t": datetime(2026, 6, 4, tzinfo=UTC)}
|
|
|
|
def behavior(trade):
|
|
raise LedgerRetryableError("503 upstream")
|
|
|
|
outbox, ledger, writer = _wire(
|
|
behavior, clock=lambda: now["t"], retry_base_sec=10.0, max_attempts=99,
|
|
)
|
|
outbox.enqueue(_trade())
|
|
assert writer.run_once().retryable == 1
|
|
[item] = outbox.all_items()
|
|
assert item.status is WorkItemStatus.PENDING and item.next_retry_at is not None
|
|
# within backoff window -> skipped (no adapter call)
|
|
calls_before = ledger.calls
|
|
assert writer.run_once().retryable == 0
|
|
assert ledger.calls == calls_before
|
|
# advance past backoff -> retried
|
|
now["t"] += timedelta(seconds=60)
|
|
assert writer.run_once().retryable == 1
|
|
assert ledger.calls == calls_before + 1
|
|
|
|
|
|
def test_retryable_dead_letters_after_max_attempts():
|
|
"""S-2: retryable exhausts max_attempts → delivery_failed (dead-letter)."""
|
|
now = {"t": datetime(2026, 6, 4, tzinfo=UTC)}
|
|
|
|
def behavior(trade):
|
|
raise LedgerRetryableError("503 upstream")
|
|
|
|
outbox, ledger, writer = _wire(
|
|
behavior, clock=lambda: now["t"], retry_base_sec=1.0, retry_cap_sec=2.0,
|
|
max_attempts=3,
|
|
)
|
|
outbox.enqueue(_trade())
|
|
# attempt 1, 2 -> retryable; attempt 3 -> dead-letter
|
|
assert writer.run_once().retryable == 1
|
|
now["t"] += timedelta(seconds=10)
|
|
assert writer.run_once().retryable == 1
|
|
now["t"] += timedelta(seconds=10)
|
|
s = writer.run_once()
|
|
assert s.delivery_failed == 1
|
|
[item] = outbox.all_items()
|
|
assert item.status is WorkItemStatus.DELIVERY_FAILED
|
|
assert item.last_outcome is OutboxOutcome.DEAD_LETTERED
|
|
assert item.attempts == 3
|
|
|
|
|
|
def test_permanent_failure_emits_warning(caplog):
|
|
"""S-3: terminal delivery_failed is visible (WARN), not silent."""
|
|
now = {"t": datetime(2026, 6, 4, tzinfo=UTC)}
|
|
|
|
def behavior(trade):
|
|
raise LedgerPermanentError("404 not found")
|
|
|
|
outbox, ledger, writer = _wire(behavior, clock=lambda: now["t"])
|
|
outbox.enqueue(_trade())
|
|
with caplog.at_level(logging.WARNING):
|
|
writer.run_once()
|
|
assert any("delivery_failed" in r.message for r in caplog.records)
|
|
|
|
|
|
def test_backoff_row_does_not_block_new_rows():
|
|
"""S-4: a backing-off row does not occupy the FIFO batch; new rows proceed."""
|
|
now = {"t": datetime(2026, 6, 4, tzinfo=UTC)}
|
|
|
|
def behavior(trade):
|
|
if trade.asset_id == "PF-bad":
|
|
raise LedgerRetryableError("503")
|
|
return LedgerWriteOutcome(LedgerWriteResult.NEW)
|
|
|
|
outbox, ledger, writer = _wire(
|
|
behavior, clock=lambda: now["t"], retry_base_sec=100.0, max_attempts=99,
|
|
)
|
|
outbox.enqueue(_trade(cid_suffix="bad", asset="PF-bad"))
|
|
writer.run_once() # PF-bad -> backoff
|
|
outbox.enqueue(_trade(cid_suffix="good", asset="PF-good"))
|
|
s = writer.run_once() # PF-bad skipped (backoff), PF-good completes
|
|
assert s.completed == 1 and s.retryable == 0
|
|
good = outbox.get("PF-good:O-good:e-good")
|
|
assert good.status is WorkItemStatus.COMPLETED
|