genichinandClaude Opus 4.8
63da87c9b3
`trex-core slots` 가 snapshot RPC 의 universe `assets`(portfolio)를 슬롯 상태로 오인 표시하던 갭 정정. snapshot envelope 이 슬롯 상태를 운반하지 않아 발생 (10개 슬롯인데 universe 1개·status 없음 — BAT-007 HTTP 슬롯 read 제거 후 슬롯 상태 read 표면 부재가 근인). - REQ-028 (CHG-20260608-01): snapshot envelope 에 read-only per-slot `slots[]` additive 추가(AC-4). strategy `assets[]`(universe, no-price) 불변. - REQ-032 (CHG-20260608-03): `_cmd_slots` 가 envelope `slots[]`(실제 슬롯 상태) 표시 + `--status` 를 슬롯 status 기준 client-side 필터 + watchdog 결합. `universe` 는 `assets[]` 유지. `universe --json` 도 universe 데이터로 scope. - canonical `portfolio.slot_to_dict` 단일화 — BAT-007 stub / BAT-008 envelope 두 경로가 동일 슬롯 스키마(외부명 `entry_price` 유지, dcy-012 호환). - interface-contract 에 `slots[]` 계약 + `assets[]` vs `slots[]` 구분 반영. 검증: 단위 338 passed + ruff clean + 신규 코드 데몬으로 실 PostgreSQL/RabbitMQ 운영 재현 PASS(slots=10·status·DB 일치·universe 분리·비침습). REQ-028/032 Implemented, BAT-022 release-candidate. pytest 인프라 게이트는 Human Approval Memo 수용(운영 재현이 실 경로 커버). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
96 lines
3.3 KiB
Python
96 lines
3.3 KiB
Python
"""Snapshot RPC handler envelope path (REQ-028 AC-1/AC-2/AC-3)."""
|
|
from __future__ import annotations
|
|
|
|
from datetime import date
|
|
|
|
from trex_core.application.messaging import RpcRequest
|
|
from trex_core.application.messaging_handlers import make_snapshot_rpc_handler
|
|
from trex_core.application.portfolio import (
|
|
DegradedReason,
|
|
InMemoryPauseStore,
|
|
PortfolioItem,
|
|
SnapshotStore,
|
|
)
|
|
from trex_core.domain.slot import SlotService
|
|
from trex_core.domain.slot.in_memory_repository import InMemorySlotRepository
|
|
|
|
DAY = date(2026, 6, 5)
|
|
|
|
|
|
def _wire(items=None):
|
|
repo = InMemorySlotRepository()
|
|
svc = SlotService(repo)
|
|
svc.preallocate_daily_slots(DAY, 5)
|
|
store = SnapshotStore()
|
|
store.swap(items or [
|
|
PortfolioItem(portfolio_id="pf-A", symbol="005930",
|
|
cash_balance=1_000_000, asset_quantity=0,
|
|
active_strategy_id="target-value-v1",
|
|
strategy_params={"k": 1}),
|
|
])
|
|
pause = InMemoryPauseStore()
|
|
handler = make_snapshot_rpc_handler(
|
|
repo, svc,
|
|
snapshot_store=store, pause_store=pause, default_total_slots=5,
|
|
)
|
|
return store, pause, handler
|
|
|
|
|
|
def test_envelope_shape_returned():
|
|
_, _, handler = _wire()
|
|
resp = handler(RpcRequest(
|
|
payload={"view": "all", "trading_date": DAY.isoformat()},
|
|
correlation_id="snap-1",
|
|
))
|
|
body = resp.payload
|
|
# BAT-022: `slots[]` additive operator-facing per-slot state.
|
|
assert set(body.keys()) == {"assets", "view", "available_slots", "degraded",
|
|
"reason", "message", "slots"}
|
|
assert isinstance(body["assets"], list)
|
|
assert isinstance(body["slots"], list)
|
|
assert body["view"] == "all"
|
|
assert body["degraded"] is False
|
|
assert body["reason"] is None
|
|
|
|
|
|
def test_envelope_strategy_key_filter():
|
|
_, _, handler = _wire([
|
|
PortfolioItem(portfolio_id="x", symbol="X", cash_balance=0, asset_quantity=0,
|
|
active_strategy_id="alpha"),
|
|
PortfolioItem(portfolio_id="y", symbol="Y", cash_balance=0, asset_quantity=0,
|
|
active_strategy_id="beta"),
|
|
])
|
|
resp = handler(RpcRequest(
|
|
payload={"view": "all", "strategy_key": "alpha"}, correlation_id="snap-2",
|
|
))
|
|
pids = {a["asset_id"] for a in resp.payload["assets"]}
|
|
assert pids == {"x"}
|
|
|
|
|
|
def test_degraded_signal_does_not_leak_credentials():
|
|
store, _, handler = _wire()
|
|
store.set_degraded(
|
|
DegradedReason.PORTFOLIO_HUB_UNAVAILABLE,
|
|
"GET https://hub failed: 401 Bearer secret-token-abc",
|
|
)
|
|
resp = handler(RpcRequest(payload={"view": "all"}, correlation_id="snap-3"))
|
|
body = resp.payload
|
|
assert body["degraded"] is True
|
|
assert body["reason"] == "portfolio_hub_unavailable"
|
|
assert body["message"] is not None
|
|
assert "secret-token-abc" not in body["message"]
|
|
|
|
|
|
def test_bat007_legacy_path_when_stores_unset():
|
|
"""Make sure pre-BAT-008 callers still work (slots+capacity stub shape)."""
|
|
repo = InMemorySlotRepository()
|
|
svc = SlotService(repo)
|
|
svc.preallocate_daily_slots(DAY, 3)
|
|
handler = make_snapshot_rpc_handler(repo, svc)
|
|
resp = handler(RpcRequest(
|
|
payload={"view": "all", "trading_date": DAY.isoformat()}, correlation_id="legacy",
|
|
))
|
|
body = resp.payload
|
|
assert "slots" in body and "capacity" in body
|
|
assert "assets" not in body
|