genichinandClaude Opus 4.8
b851b927ee
portfolio-hub 404(미등록 포트폴리오)가 retryable 로 분류되어 백오프·상한 없이 초당 영구 재시도되던 버그(issue #13, 실측 930회) 정정. 거버넌스: 전부 change-req (신규 REQ 없음, dcy-015 OQ-3; 백오프 env 는 REQ-019 흡수). - REQ-017: 404/400/422 → LedgerPermanentError 분류 (409 conflict / 408·429·5xx· network retryable 불변). LedgerPort 에 permanent 타입 추가 - REQ-019: 영속 → 터미널 delivery_failed 즉시(재시도 0). retryable 지수 백오프 +jitter+next_retry_at, max_attempts 초과 시 dead-letter delivery_failed. list_pending 이 백오프 행 스킵(head-of-line 보호). 마이그레이션 007(status enum +next_retry_at). 백오프 env(base/cap/max-attempts) - REQ-018: 터미널/dead-letter WARN + WriterStats.delivery_failed 카운터 가시화 - REQ-020: runtime-flows/data-model/interface-contract 정합 단일 터미널 delivery_failed(permanent/dead-letter, last_outcome 로 사유 구분) — conflict_blocked 패턴과 동형. dead-letter 는 운영자 재처리 가능 상태. 검증: 단위 311 passed/34 skipped, 인프라 게이트(PG+RabbitMQ) 345 passed, ruff clean. 신규 test_ledger_outbox_backoff + adapter/PG 테스트, 기존 retryable 백오프 정합. BAT-019 release-candidate. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
71 lines
2.7 KiB
Python
71 lines
2.7 KiB
Python
"""LedgerOutbox + LedgerWriter direct unit tests (REQ-019)."""
|
|
from __future__ import annotations
|
|
|
|
from datetime import datetime, timedelta, timezone
|
|
|
|
from trex_core.adapters.ledger.in_memory import InMemoryLedger
|
|
from trex_core.application.ledger_outbox import (
|
|
InMemoryLedgerOutbox,
|
|
LedgerWriter,
|
|
OutboxOutcome,
|
|
WorkItemStatus,
|
|
)
|
|
from trex_core.application.ledger_port import LedgerTrade
|
|
|
|
|
|
def _trade(execution_id="paper:PAPER-1:10") -> LedgerTrade:
|
|
return LedgerTrade(
|
|
asset_id="PF-1", order_id="PAPER-1", execution_id=execution_id,
|
|
side="buy", qty=10, price=1000.0,
|
|
executed_at=datetime(2026, 6, 4, tzinfo=timezone.utc),
|
|
)
|
|
|
|
|
|
def test_enqueue_is_idempotent_on_correlation_id():
|
|
outbox = InMemoryLedgerOutbox()
|
|
a = outbox.enqueue(_trade())
|
|
b = outbox.enqueue(_trade())
|
|
assert a.correlation_id == b.correlation_id
|
|
assert len(outbox.all_items()) == 1
|
|
|
|
|
|
def test_writer_run_once_drains_pending_and_marks_completed():
|
|
outbox = InMemoryLedgerOutbox()
|
|
ledger = InMemoryLedger()
|
|
writer = LedgerWriter(outbox, ledger)
|
|
outbox.enqueue(_trade(execution_id="e-1"))
|
|
outbox.enqueue(_trade(execution_id="e-2"))
|
|
stats = writer.run_once()
|
|
assert stats.completed == 2 and ledger.count() == 2
|
|
assert all(it.status is WorkItemStatus.COMPLETED for it in outbox.all_items())
|
|
assert all(it.last_outcome is OutboxOutcome.COMPLETED for it in outbox.all_items())
|
|
|
|
|
|
def test_writer_marks_conflict_blocked_and_does_not_retry():
|
|
outbox = InMemoryLedgerOutbox()
|
|
ledger = InMemoryLedger(conflict_executions={"e-x"})
|
|
writer = LedgerWriter(outbox, ledger)
|
|
outbox.enqueue(_trade(execution_id="e-x"))
|
|
writer.run_once()
|
|
[item] = outbox.all_items()
|
|
assert item.status is WorkItemStatus.CONFLICT_BLOCKED
|
|
assert item.last_outcome is OutboxOutcome.CONFLICT_BLOCKED
|
|
# No pending items remain, so a subsequent run is a no-op.
|
|
assert outbox.list_pending() == []
|
|
|
|
|
|
def test_writer_retries_until_success():
|
|
# dcy-015: retryable rows now back off; share an injected clock between the
|
|
# outbox (list_pending "now") and the writer (next_retry_at) to advance past it.
|
|
now = {"t": datetime(2026, 6, 4, tzinfo=timezone.utc)}
|
|
outbox = InMemoryLedgerOutbox(clock=lambda: now["t"])
|
|
ledger = InMemoryLedger(fail_n_then_succeed=1)
|
|
writer = LedgerWriter(outbox, ledger, clock=lambda: now["t"])
|
|
outbox.enqueue(_trade(execution_id="e-r"))
|
|
s1 = writer.run_once()
|
|
assert s1.retryable == 1 and ledger.count() == 0
|
|
assert writer.run_once().completed == 0 # still in backoff -> skipped
|
|
now["t"] += timedelta(seconds=600) # past the backoff window
|
|
s2 = writer.run_once()
|
|
assert s2.completed == 1 and ledger.count() == 1
|