44 lines
2.3 KiB
Markdown
44 lines
2.3 KiB
Markdown
# BAT-014 Verification
|
||
|
||
## Verification summary
|
||
|
||
Status: PASS
|
||
|
||
All required code-path checks for BAT-014 passed. A manual local browser-evidence launch was attempted but blocked by the runtime’s consent guard for long-running local server startup, so the close-out evidence uses AppTest + full pytest + MCP discovery + structural call-site verification. No production ledger DB or real financial files were used.
|
||
|
||
## Acceptance criteria evidence
|
||
|
||
### AC-1. MCP contract/helper seam and Streamlit page/domain gateways exist
|
||
- Evidence:
|
||
- `jarca_ledger_mcp/adapters/mcp/tool_contracts.py` added and `adapters/mcp/server.py` now calls `contracts.*`.
|
||
- `search_files('*_gateway.py')` under `adapters/streamlit` returned 9 gateway/aggregator files.
|
||
|
||
### AC-2. `dashboard/app.py` no longer uses a flat broad gateway surface
|
||
- Evidence:
|
||
- `search_files(pattern='service\\.', path='dashboard', file_glob='app.py')` returned 0 matches after rewiring.
|
||
- Dynamic hot-reload lookup now targets passed gateway modules (`categorization_gateway`, `transfers_gateway`) instead of a flat `service` binding.
|
||
|
||
### AC-3. Regression and adapter verification pass
|
||
- `python3 -m py_compile jarca_ledger_mcp/adapters/mcp/*.py jarca_ledger_mcp/adapters/streamlit/*.py dashboard/app.py` → PASS
|
||
- `pytest -q tests/test_dashboard_app.py` → PASS (`....`)
|
||
- `pytest -q` → PASS (`........................ss...............ss...`)
|
||
- `hermes mcp test jarca-ledger` → PASS, 56 tools discovered
|
||
|
||
### AC-4. Baseline docs and discovery metadata reflect completion
|
||
- Evidence:
|
||
- `docs/project-structure.md` updated with new owning services, parser seam, MCP contract helper, and Streamlit page/domain gateways.
|
||
- `docs/runtime-flows.md` updated with import/parser seam, MCP contract routing, and dashboard gateway flow.
|
||
- dcy-011 metadata and close-out notes updated to reference `REQ-015`~`REQ-018` / `BAT-011`~`BAT-014` completion.
|
||
|
||
## Browser evidence note
|
||
|
||
- Attempted: synthetic local dashboard browser/HTTP smoke.
|
||
- Result: blocked by terminal consent guard for long-running local server startup in this session.
|
||
- Impact: none on code correctness regression; AppTest remained green and no UI functional regression was detected in test coverage.
|
||
|
||
## Safety boundary
|
||
|
||
- Synthetic/temp DBs only.
|
||
- No destructive migration.
|
||
- No production ledger DB mutation.
|