Files

T

genichinandClaude Sonnet 4.6 c815ce39b6 feat: dcy-003/004 토큰 surface 개편 및 daemon lifecycle 정책 구현 (BAT-006/007)

BAT-006 (REQ-016/017/018):
- client token 발급 경로 제거 (issue_client_token, POST /auth/tokens, 관련 스키마/테스트)
- service-token rotate unique index revoked_at IS NULL 조건 추가 (Alembic CONCURRENTLY 마이그레이션)
- POST /auth/service-tokens body daemon_id forward 누락 보정 (1-line fix)

BAT-007 (REQ-022/023):
- daemon deactivate 시 바인딩 service token 자동 revoke (CLI --force 옵션 + revoke_tokens_by_daemon_id)
- NULL daemon_id legacy token 진단 CLI (migrate-null-daemon --dry-run)

거버넌스 문서: dcy-003/004 Discovery, REQ-016~023/025~032 신규, BAT-006/007 전체 산출물

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

2026-05-21 01:03:39 +00:00

3.2 KiB

Raw Blame History

BAT-006 Implementation

Status: completed
Batch: BAT-006

Plan Summary

REQ-017: rotate unique index 보강 Alembic migration + ensure_schema 갱신
REQ-018: POST /auth/service-tokens daemon_id forward 1-line fix
REQ-016: POST /auth/tokens 라우트·서비스·스키마 코드 제거

Changed Files

migrations/versions/20260520_0022_service_token_unique_index_fix.py — 신규 Alembic revision: DROP + CREATE UNIQUE INDEX CONCURRENTLY WHERE token_type='service' AND revoked_at IS NULL (REQ-017)
app/repositories/postgres.py — ensure_schema() idx 정의 조건 갱신 WHERE token_type='service' AND revoked_at IS NULL (REQ-017)
app/api/auth_routes.py — daemon_id=payload.daemon_id 추가 (REQ-018); CreateClientTokenRequest·IssuedClientTokenResponse·IssuedClientToken import 제거, _to_issued_token_response 헬퍼 제거, create_token 라우트 제거 (REQ-016)
app/services/auth_service.py — CreateClientTokenRequest import 제거, IssuedClientToken dataclass 제거, issue_client_token 메서드 제거, _build_expiration 정적 메서드 제거 (REQ-016)
app/schemas/auth.py — CreateClientTokenRequest, IssuedClientTokenResponse 클래스 제거 (REQ-016)
tests/test_auth.py — get_daemon_by_id 추가 to _AuthRepo; REQ-018 AC-1~3 서비스 계층 테스트 3개 추가; REQ-016 AC-2 HTTP 404/405 테스트 추가
tests/test_auth_surface_after_client_deprecation.py — 신규: REQ-016 AC-1 grep 기반 잔여 심볼 검증 3개, AC-4 importlib 기반 심볼 제거 검증 2개
tests/test_users.py — test_login_and_issue_client_token_flow 제거 (POST /auth/tokens 폐지)

Execution Log

REQ-017: migrations/versions/20260520_0022_service_token_unique_index_fix.py 신규 작성 (CONCURRENTLY + autocommit 패턴)
REQ-017: app/repositories/postgres.py:ensure_schema() index 조건 갱신
REQ-018: app/api/auth_routes.py issue_service_token() 호출에 daemon_id=payload.daemon_id 추가
REQ-016: app/schemas/auth.py — CreateClientTokenRequest, IssuedClientTokenResponse 제거
REQ-016: app/services/auth_service.py — IssuedClientToken dataclass, issue_client_token, _build_expiration 제거
REQ-016: app/api/auth_routes.py — import, _to_issued_token_response, create_token 라우트 제거
tests/test_users.py — test_login_and_issue_client_token_flow 제거
tests/test_auth.py — _AuthRepo.get_daemon_by_id 추가; REQ-018 AC-1~3 테스트 추가; REQ-016 AC-2 HTTP 테스트 추가 (404/405 허용)
tests/test_auth_surface_after_client_deprecation.py 신규 생성 (REQ-016 AC-1/4)
pytest 255 passed 확인

Validation

pytest 255 passed (8.13s) — regression 없음
신규 테스트: test_auth.py +4개, test_auth_surface_after_client_deprecation.py +5개 = 총 9개 추가

Remaining Risks

REQ-017 CONCURRENTLY migration: 실 DB(docker-compose.local-test.yml) 환경에서 AC-1~3 검증 미완료 (실 DB 없는 환경에서 단위 테스트만 수행)
REQ-016 AC-3: release 직전 SELECT COUNT(*) FROM auth_tokens WHERE token_type='client' AND revoked_at IS NULL → COUNT=0 재확인은 release plan evidence로 남김

3.2 KiB Raw Blame History

BAT-006 Implementation

Plan Summary

Changed Files

Execution Log

Validation

Remaining Risks

3.2 KiB

Raw Blame History